Request info in logs

Bug #1500222 reported by Brant Knudson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Brant Knudson

Bug Description

The oslo.log standard format for log messages includes a bunch of info about the request, the user tenant domain user_domain and project_domain

These are included in nova logs.

For keystone, these aren't included in the log for the request and they should be when available to make it easier for admins to debug issues.

From http://git.openstack.org/cgit/openstack/oslo.context/tree/oslo_context/context.py?id=f8285a1f3499a308d3e3f98645ddd56a41e593f8#n75 :

    self.user_idt_format.format(user=self.user or '-',
                                        tenant=self.tenant or '-',
                                        domain=self.domain or '-',
                                        user_domain=self.user_domain or '-',
                                        p_domain=self.project_domain or '-'))

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/228269

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/213792
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7d20f0edf6108d68940a6715d9199afcbae15b9d
Submitter: Jenkins
Branch: master

commit 7d20f0edf6108d68940a6715d9199afcbae15b9d
Author: Brant Knudson <email address hidden>
Date: Mon Aug 17 10:59:08 2015 -0500

    Add user_domain_id, project_domain_id to auth context

    When creating the auth context, also include the user's domain ID
    and project domain ID.

    Partial-Bug: 1500222
    Change-Id: I31c42fe1d0d484cb2af2259acda8b3c7fd75e309

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/228269
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f2cb4aec384401eb8f078f2db10771f36032ce01
Submitter: Jenkins
Branch: master

commit f2cb4aec384401eb8f078f2db10771f36032ce01
Author: Brant Knudson <email address hidden>
Date: Sun Sep 27 11:21:03 2015 -0500

    Add unit test for creating RequestContext

    There wasn't a unit test that shows that AuthContextMiddleware
    creates an oslo_context.RequestContext.

    Change-Id: I9094df5c99121640668c8b468aa261d065b41d30
    Partial-Bug: 1500222

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/213595
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=fc9e016dfe6440ff3ff9aac69521bd6d2d627565
Submitter: Jenkins
Branch: master

commit fc9e016dfe6440ff3ff9aac69521bd6d2d627565
Author: Brant Knudson <email address hidden>
Date: Sun Aug 16 22:14:27 2015 -0500

    More info in RequestContext

    The OpenStack standard log format string contains fields for
    user ID, project ID, etc., that will be displayed if the
    appropriate fields are set in the RequestContext. This change sets
    the fields in the RequestContext.

    Closes-Bug: 1500222
    Change-Id: I4ae6da483cfae98f910a2905e80b6af606ae6468

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → mitaka-1
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/keystone 9.0.0.0b1

This issue was fixed in the openstack/keystone 9.0.0.0b1 development milestone.

Changed in keystone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.