envionment markers with comments error in pbr

Bug #1494330 reported by Brant Knudson
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Confirmed
Critical
Brant Knudson

Bug Description

https://review.openstack.org/#/c/222000/ in keystone is a new requirements update that came after https://review.openstack.org/203336 requirements update.

the keystone change is failing, when I run it locally the output includes:

  Running setup.py install for keystone
    Complete output from command /opt/stack/keystone/.tox/py27/bin/python2.7 -c "import setuptools, tokenize;__file__='/tmp/pip-UCUFAy-build/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-ZKQdft-record/install-record.txt --single-version-externally-managed --compile --install-headers /opt/stack/keystone/.tox/py27/include/site/python2.7/keystone:
    error in setup command: Invalid environment marker: (python_version=='2.7' # MPL)
So it looks like something isn't handling comments in setup.cfg lines, or comments can't be put in setup.cfg lines.

A couple of options:

1) Remove the comment from the global requirements file.
2) Have the requirements update tool strip comments when updating setup.cfg.
3) Maybe it's pbr that needs to handle it?

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Brant Knudson (blk-u)
Changed in keystone:
importance: Medium → Critical
Dolph Mathews (dolph)
Changed in keystone:
status: New → Confirmed
Brant Knudson (blk-u)
Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
Brant Knudson (blk-u)
description: updated
description: updated
Revision history for this message
Brant Knudson (blk-u) wrote :

Proposed change to requirements update tool -- https://review.openstack.org/#/c/222236/

Changed in keystone:
milestone: none → liberty-rc1
summary: - Requirements update is failing
+ envionment markers with comments error in pbr
Revision history for this message
Robert Collins (lifeless) wrote :

I've reproduced with pbr 1.7.0

keystone$ pip list
docopt (0.6.2)
extras (0.0.3)
formasaurus (0.2)
linecache2 (1.0.0)
pbr (1.7.0)
pip (7.1.2)
python-mimeparse (0.1.4)
setuptools (18.3.1)
six (1.9.0)
testtools (1.8.0)
tldextract (1.6)
tqdm (1.0)
traceback2 (1.4.0)
unittest2 (1.1.0)
wheel (0.24.0)
zope.component (4.2.2)
zope.event (4.0.3)
zope.i18nmessageid (4.0.3)
zope.interface (4.1.2)
zope.location (4.0.3)
zope.proxy (4.1.6)
zope.schema (4.4.2)
zope.security (3.8.3)
zope.untrustedpython (4.0.0)

python setup.py egg_info
error in setup command: Invalid environment marker: (python_version=='2.7' # MPL)

git pull https://review.openstack.org/openstack/keystone refs/changes/00/222000/1 in a keystone tree to setup the environment

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.