Wrong handling of domain_id passed as None

[Henrique Truta]

Keystone does not handle the domain_id passed as none in controller layer, as in:

https://github.com/openstack/keystone/blob/master/keystone/common/controller.py#L743

[lei zhang (zhang-lei)]

domain_id is not a variable, it can't be None

as in: https://github.com/openstack/keystone/blob/master/keystone/common/controller.py#L743

This step is just to judge whether ref['domain_id'] is already exists

[David Stanek (dstanek)]

@Lei, I think the key can be None from the V2 API. I think most cases in V3 make it a string or it can't be provided at all.

@Henrique, How is the handing wrong?

[Henrique Truta (henriquetruta)]

@David, we are not handling domain_id None... In project creation, it should look at the token to get the domain_id in case None or nothing was provided. See Henry's comment here: https://review.openstack.org/#/c/213448/6/keystone/common/controller.py

@Lei see the link above

[Henrique Truta (henriquetruta)]

Marking as invalid, as this is a new behaviour and should be fixed in this same patch.