Assertion signing error causes TypeError for Message objects do not support addition

[Brant Knudson]

If running the xmlsec1 binary fails with some output, rather than getting the log of the error you'll get a TypeError exception with the message "Message objects do not support addition.". This is because oslo.i18n Message objects don't support addition, which the code is attempting to do.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/212845

[Dolph Mathews (dolph)]

Fixed by https://review.openstack.org/#/c/203047/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/212845
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e16aa8e5e5429ebbfb3d2086a22c8acc52c1b6cf
Submitter: Jenkins
Branch: master

commit e16aa8e5e5429ebbfb3d2086a22c8acc52c1b6cf
Author: Brant Knudson <email address hidden>
Date: Thu Aug 13 18:30:28 2015 -0500

    Enhance tests for saml2 signing exception logging

    There was no test that verified that the log message was generated
    correctly when there was an exception from the xmlsec1 binary. The
    test shows that the log message isn't generated correctly but
    instead causes a TypeError to be raised.

    The test__sign_assertion_fileutils_exc test is also enhanced to
    verify that the error is logged correctly.

    Change-Id: I5b7c22d27bad241339fdacae8b61973d45d55d30
    Partial-Bug: 1484735

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/203047
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=82bddf17cdcf7c8f183b2122f8c2f759eddb5da4
Submitter: Jenkins
Branch: master

commit 82bddf17cdcf7c8f183b2122f8c2f759eddb5da4
Author: Brant Knudson <email address hidden>
Date: Fri Jul 17 09:20:43 2015 -0500

    Fix logging in federation/idp.py

    The existing code would raise a TypeError exception:

      TypeError: Message objects do not support addition.

    This is because oslo.i18n Message objects do not support the +
    operator and instead require substitution to be used.

    Closes-Bug: 1484735
    Change-Id: I65e093808b243d8eff5b3cefdf6d64c3d7216801