H405 violations: multi line docstring summary not separated with an empty line

[Dolph Mathews]

Keystone's tox.ini contains an "ignore" entry for H405. All violations of H405 should be fixed so that H405 can be removed from the ignore list.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210607

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211023

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/210607
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=bf1e9e3995b031b54589683984d517339062d6dd
Submitter: Jenkins
Branch: master

commit bf1e9e3995b031b54589683984d517339062d6dd
Author: Dolph Mathews <email address hidden>
Date: Fri Aug 7 21:21:18 2015 +0000

    Improve a few random docstrings (H405)

    This is primarily in support of H405, but I took the opportunity to
    clean up a few spelling and grammar issues along the way.

    Change-Id: If3e81caca46a2c3d1b76af58d67ba9f9a9172aff
    Partial-Bug: 1482773

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211023
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=bc999e2a35281be9883617de7e3b51428b423f64
Submitter: Jenkins
Branch: master

commit bc999e2a35281be9883617de7e3b51428b423f64
Author: Dave Chen <email address hidden>
Date: Mon Aug 10 15:53:34 2015 +0800

    Improve a few random docstrings

    - For triple-quoted strings, always use double quote characters to be
    consistent with the docstring convention in PEP 257.
    - Multi line docstrings should start with a one line summary followed
    by an empty line

    Change-Id: I591cd69f0ec9e7caabf559de09df422911dab91b
    Partial-Bug: 1482773

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238161

[Tom Cocozzello (tjcocozz-deactivatedaccount)]

FYI

When the ignore is not defined the tox.ini the default flake8
error codes that will be ignored are E123/E133, E226 and E241/E242.

Here is the doc:
http://flake8.readthedocs.org/en/latest/config.html#default

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/243889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243889
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=63429aeca8f2e88dc1ff1b8b1131386165d4018f
Submitter: Jenkins
Branch: master

commit 63429aeca8f2e88dc1ff1b8b1131386165d4018f
Author: lin-hua-cheng <email address hidden>
Date: Tue Nov 10 17:54:33 2015 -0800

    Address hacking check H405

    Previously, there were a string of commits to keystone that addresed ignored
    hacking checks. This commit does the same for H405 in keystoneauth. This
    also modifies our tox.ini so that we no longer ignore H405 violations.

    Change-Id: I0ac1165f309edd486639e2729c18330b1d062eb3
    Closes-Bug: 1482773

[Lin Hua Cheng (lin-hua-cheng)]

middleware patch: https://review.openstack.org/#/c/238161/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238161
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=01297dce1a24d8506093f3a8c89c4e7484e9402c
Submitter: Jenkins
Branch: master

commit 01297dce1a24d8506093f3a8c89c4e7484e9402c
Author: Lance Bragstad <email address hidden>
Date: Wed Oct 21 16:37:58 2015 +0000

    Address hacking check H405.

    Previously, there were a string of commits to keystone that addresed ignored
    hacking checks. This commit does the same for H405 in keystonemiddleware. This
    also modifies our tox.ini so that we no longer ignore H405 violations.

    This is a non-functional change.

    Change-Id: I7bbe99719feb39e96634c903991294c18c33112b
    Closes-Bug: 1482773

[Doug Hellmann (doug-hellmann)]

This issue was fixed in openstack/keystoneauth 2.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in openstack/keystonemiddleware 4.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267172

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267172
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=77ed0d4d0c3413b15aa348613b8b40373bd5765b
Submitter: Jenkins
Branch: master

commit 77ed0d4d0c3413b15aa348613b8b40373bd5765b
Author: lin-hua-cheng <email address hidden>
Date: Wed Jan 13 13:03:51 2016 -0800

    Address hacking check H405

    Previously, there were a string of commits to keystone that addresed ignored
    hacking checks. This commit does the same for H405 in keystoneclient. This
    also modifies our tox.ini so that we no longer ignore H405 violations.

    Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680
    Closes-Bug: 1482773

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278190

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-keystoneclient 2.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/278190
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=2bad130bf457ab4b23b65f9b407a8cc8bde300fe
Submitter: Jenkins
Branch: master

commit 2bad130bf457ab4b23b65f9b407a8cc8bde300fe
Author: Tin Lam <email address hidden>
Date: Tue Feb 9 20:18:35 2016 -0600

    Removing H405 violations from keystone

    Keystone's tox.ini contains an "ignore" entry for H405 violations:
    multi line docstring summary not separated with an empty line.
    All violations of H405 should be fixed so that H405 can be removed
    from the ignore list.

    Change-Id: I1b2aae0cabc20909cf3b0a405d5e31c5d91148b2
    Closes-Bug: #1482773

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/keystone 9.0.0.0b3 development milestone.