Non-numeric filenames in key_repository will make Keystone explode

Bug #1478656 reported by Clint Byrum
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Clint Byrum
Kilo
Fix Released
Low
Dolph Mathews

Bug Description

If one makes any files in that directory, such as an editor backup, Keystone will explode on startup or at the next key rotation because it assumes all files will pass int(filename)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206177

Changed in keystone:
assignee: nobody → Clint Byrum (clint-fewbar)
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
tags: added: fernet
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/206177
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7223bb1c035d98ebb1a49e115f05cb69ad7928d4
Submitter: Jenkins
Branch: master

commit 7223bb1c035d98ebb1a49e115f05cb69ad7928d4
Author: Clint Byrum <email address hidden>
Date: Mon Jul 27 11:14:30 2015 -0700

    Handle non-numeric files in key_repository

    It is very likely administrators will leave behind bits and pieces in a
    live environment. One cannot assume that all of the files in a directory
    will be the ones created by Keystone.

    Change-Id: I5841a11f599f79d2efbe1a176f499e280a91cb37
    Closes-Bug: #1478656

Changed in keystone:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
tags: added: user-experience
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/207495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/kilo)

Reviewed: https://review.openstack.org/207495
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=6c106e980075a301b21e1907ab0c681dd5d91e88
Submitter: Jenkins
Branch: stable/kilo

commit 6c106e980075a301b21e1907ab0c681dd5d91e88
Author: Clint Byrum <email address hidden>
Date: Mon Jul 27 11:14:30 2015 -0700

    Handle non-numeric files in key_repository

    It is very likely administrators will leave behind bits and pieces in a
    live environment. One cannot assume that all of the files in a directory
    will be the ones created by Keystone.

    Change-Id: I5841a11f599f79d2efbe1a176f499e280a91cb37
    Closes-Bug: #1478656
    (cherry picked from commit 7223bb1c035d98ebb1a49e115f05cb69ad7928d4)

Changed in keystone:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.