using pysaml2 version 3.0.0 breaks keystone in kilo release 2015.1.0

Bug #1475796 reported by Marcos Simental
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Marcos Simental
Kilo
Fix Released
High
Unassigned

Bug Description

pysaml2 version 3.0.0 it's a major change as specified in [1]:
"2)All parts of the package is now collected in one module. This is a change that breaking change compared to earlier releases hence the major version change.".

when running keystone release 2015.1.0 with python package pysaml2 version 3.0.0 breaks it with the following error:
  File "/usr/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 22, in import_string
    return pkg_resources.EntryPoint.parse("x=" + s).load(False)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2355, in load
    return self.resolve()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2361, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/routers.py", line 17, in <module>
    from keystone.contrib.federation import controllers
  File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/controllers.py", line 29, in <module>
    from keystone.contrib.federation import idp as keystone_idp
  File "/usr/lib/python2.7/site-packages/keystone/contrib/federation/idp.py", line 29, in <module>
    import xmldsig
ImportError: No module named xmldsig

This is due to the new location for xmldsig module:
xmldsig -> saml2/xmldsig
done in commit [2].

Possible fixes are:

1) require pysaml2 version <3.0.0
2) cherry-pick patch from kesytone master branch with the proper fix [3]

[1] - https://github.com/rohe/pysaml2/releases/tag/3.0.0
[2] - https://github.com/rohe/pysaml2/commit/9af3252035484f4a8c624eba0f35b68280d43fd2
[3] - https://github.com/openstack/keystone/commit/c90dd3a0f8280e28bbbff691c0ae27aff736658a

Changed in keystone:
assignee: nobody → Marcos Simental (mrkzmrkz)
Dolph Mathews (dolph)
tags: removed: kilo-backport-potential
Changed in keystone:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Brant Knudson (blk-u) wrote :
Revision history for this message
Brant Knudson (blk-u) wrote :
Changed in keystone:
status: Triaged → Fix Committed
Revision history for this message
Marcos Simental (mrkzmrkz) wrote :
Changed in keystone:
assignee: Marcos Simental (mrkzmrkz) → nobody
assignee: nobody → Marcos Simental (mrkzmrkz)
Changed in keystone:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-2 → 8.0.0
Revision history for this message
Steve Martinelli (stevemar) wrote :

marking this as released for kilo as we've hard multiple kilo releases for a while now

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.