Fernet unit tests do not test persistence logic

Bug #1471967 reported by Lance Bragstad on 2015-07-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Lance Bragstad
Kilo
Low
Dolph Mathews

Bug Description

There are some unit tests for the Fernet token provider that live outside of the functional-like tests (test_v3_auth.py, for example) [0]. These tests should include a test to assert that the Fernet token provider returns False when asked if it's tokens need persistence [1].

[0] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/tests/unit/token/test_fernet_provider.py
[1] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/token/providers/fernet/core.py#L36-L38

Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
status: New → In Progress
tags: added: fernet
tags: added: test-improvement
Changed in keystone:
status: In Progress → Fix Committed
Dolph Mathews (dolph) on 2015-07-09
Changed in keystone:
importance: Undecided → Low
Changed in keystone:
milestone: none → liberty-2
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/212946
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=c6ec36b17953fb637cb31fe56fa58a5873f09767
Submitter: Jenkins
Branch: stable/kilo

commit c6ec36b17953fb637cb31fe56fa58a5873f09767
Author: Lance Bragstad <email address hidden>
Date: Wed Jul 1 16:24:45 2015 +0000

    Add unit test for fernet provider

    There is some unit testing specific to the Fernet token provider that lives
    outside of the test_v3_* and test_v2 test modules. This change just adds an
    explict unit test to assert that the Fernet token providers doesn't require
    persistent storage for tokens.

    Closes-Bug: 1471967
    Change-Id: Iad9c4acc1241ec56222759998a86d0abeae143dc
    (cherry picked from commit 7d6e2a28059514dac1ea009dfb7b83dea6d1b664)

Thierry Carrez (ttx) on 2015-10-15
Changed in keystone:
milestone: liberty-2 → 8.0.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers