v3 - Ambiguous error when no request body is provided

Bug #1468597 reported by Dave Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dave Chen

Bug Description

This bug is basically the same issue as the bug described here: https://bugs.launchpad.net/keystone/+bug/1466872.
But this bug is expected to be a blanket bug as there are many entities/API have the same issue. Instead of filing a lot of bugs in the lp,let's take this as a blanket.

Example:
dave@openstack-dev:~$ curl -g -i -X POST http://localhost:35357/v3/services -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: 3ec87e90d60c4a318acf7b2bc6e55300"
HTTP/1.1 400 Bad Request
Date: Thu, 25 Jun 2015 03:37:52 GMT
Server: Apache/2.4.7 (Ubuntu)
Vary: X-Auth-Token
x-openstack-request-id: req-70c66170-271c-4e69-b5e6-67fa9ff91f59
Content-Length: 115
Content-Type: application/json
Via: 1.1 shzintpr02.sh.intel.com
Proxy-Connection: Keep-Alive
Connection: Keep-Alive

{"error": {"message": "create_service() takes exactly 3 arguments (2 given)", "code": 400, "title": "Bad Request"}}

Dave Chen (wei-d-chen)
Changed in keystone:
assignee: nobody → Dave Chen (wei-d-chen)
description: updated
description: updated
description: updated
Dave Chen (wei-d-chen)
description: updated
Changed in keystone:
status: New → In Progress
Revision history for this message
Dave Chen (wei-d-chen) wrote :
Changed in keystone:
assignee: Dave Chen (wei-d-chen) → Marek Denis (marek-denis)
Dave Chen (wei-d-chen)
Changed in keystone:
assignee: Marek Denis (marek-denis) → Dave Chen (wei-d-chen)
Dolph Mathews (dolph)
tags: added: user-experience
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Dave Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/197996
Reason: see, https://review.openstack.org/#/c/195903.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Dave Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/198280
Reason: see, https://review.openstack.org/#/c/195903.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Dave Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/195429

Dave Chen (wei-d-chen)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/214009

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/195903
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d270e8757d0142dfd87100e6f05e5488e784c6e2
Submitter: Jenkins
Branch: master

commit d270e8757d0142dfd87100e6f05e5488e784c6e2
Author: Dave Chen <email address hidden>
Date: Fri Jun 26 15:32:22 2015 +0800

    Show helpful message when request body is not provided

    Avoid showing python error when no or empty request body is provided
    for creating or updating request, providing some useful information
    instead.

    Closes-Bug: #1468597
    Closes-Bug: #1466872
    Change-Id: Ie3afc7c3591b4c1338f76d00238c541a7c54bd0d

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/214009
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7f84ff5cda4cdc7799827f90482197cd74a45371
Submitter: Jenkins
Branch: master

commit 7f84ff5cda4cdc7799827f90482197cd74a45371
Author: Dave Chen <email address hidden>
Date: Tue Aug 18 13:49:26 2015 +0800

    Remove unnecessary check

    We have done this in method validated(...) for all of the check
    against request body.

    Change-Id: I02361e279bb0229fd41e99a36198f2982b8635c2
    Related-Bug: #1468597

Changed in keystone:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.