Delete endpoint_group should remove project_endpoint_group at first

[Dave Chen]

Since the endpoint_group_id of table project_endpoint_group has a foreign key reference with the id of endpoint_group, so if we want to delete endpoint_group we need delete associated project_endpoint_group at first, or else, it will hit follow exceptions:

{"error": {"message": "An unexpected error prevented the server from fulfilling your request: (IntegrityError) (1451, 'Cannot delete or update a parent row: a foreign key constraint fails (`keystone`.`project_endpoint_group`, CONSTRAINT `project_endpoint_group_ibfk_1` FOREIGN KEY (`endpoint_group_id`) REFERENCES `endpoint_group` (`id`))') 'DELETE FROM endpoint_group WHERE endpoint_group.id = %s' ('d5c86622fea04c43b0c0e3b540417e1f',) (Disable debug mode to suppress these details.)", "code": 500, "title": "Internal Server Error"}}

[Dave Chen (wei-d-chen)]

This issue can be addressed easily by adjust current code a little bit.

https://github.com/openstack/keystone/blob/master/keystone/contrib/endpoint_filter/backends/sql.py#L148

Swith the sequence between "_delete_endpoint_group_association_by_endpoint_group" and "session.delete(endpoint_group_ref)" will work.

related BP: ondelete-cascade

Reference: https://blueprints.launchpad.net/keystone/+spec/ondelete-cascade

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/173192

[Dolph Mathews (dolph)]

Does this affect juno?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/177350

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/173192
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=4b7758c2d633d81411371134e008260baac6c05c
Submitter: Jenkins
Branch: master

commit 4b7758c2d633d81411371134e008260baac6c05c
Author: Dave Chen <email address hidden>
Date: Tue Apr 14 14:55:44 2015 +0800

    Remove project association before removing endpoint group

    Since `project_endpoint_group` has a foreign key reference with `endpoint_group`
    thus, if we want to remove endpoint_group we need to remove associated
    `project_endpoint_group` at first.

    The testcase provided can pass even without code changing only beacuse SQLITE
    didn't enforce foreign key constraint by default, so endpoint group with project
    association can be deleted (needn't delete project association at first)
    successfully.

    Closes-Bug: #1443765
    bp ondelete-cascade

    Change-Id: Id685948373ffb37467f336172a085b91c982cbc7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/177350
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=54400bfd3267caaca7daa27ec35fa963aa557f7e
Submitter: Jenkins
Branch: stable/kilo

commit 54400bfd3267caaca7daa27ec35fa963aa557f7e
Author: Dave Chen <email address hidden>
Date: Tue Apr 14 14:55:44 2015 +0800

    Remove project association before removing endpoint group

    Since `project_endpoint_group` has a foreign key reference with `endpoint_group`
    thus, if we want to remove endpoint_group we need to remove associated
    `project_endpoint_group` at first.

    The testcase provided can pass even without code changing only beacuse SQLITE
    didn't enforce foreign key constraint by default, so endpoint group with project
    association can be deleted (needn't delete project association at first)
    successfully.

    Closes-Bug: #1443765
    bp ondelete-cascade

    Change-Id: Id685948373ffb37467f336172a085b91c982cbc7
    (cherry picked from commit 4b7758c2d633d81411371134e008260baac6c05c)