A number of places where we LOG messages fail to use the _L{X} formatting

Bug #1435693 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Henry Nash
Kilo
Invalid
Low
Dolph Mathews

Bug Description

These should be corrected.

Revision history for this message
Henry Nash (henry-nash) wrote :

For example, in common/openssl:

            LOG.warn('Failed to invoke ``openssl version``, '
                     'assuming is v1.0 or newer')

should be

            LOG.warn(_LW('Failed to invoke ``openssl version``, '
                     'assuming is v1.0 or newer'))

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167124

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/167141

Changed in keystone:
milestone: kilo-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/167124
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a9183a27f70c5b371d21f26d5881ec37e1598faa
Submitter: Jenkins
Branch: master

commit a9183a27f70c5b371d21f26d5881ec37e1598faa
Author: Henry Nash <email address hidden>
Date: Tue Mar 24 07:44:35 2015 +0000

    Use correct LOG translation indicator for warnings

    There were a few places where we did not do use the _LW() indicator.

    Change-Id: I01cf0e048cad024662046386f913204068cd8050
    Partial-Bug: 1435693

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/167141
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=20fbbb4eaf9d5523d4345cac6c3d6af752da3932
Submitter: Jenkins
Branch: master

commit 20fbbb4eaf9d5523d4345cac6c3d6af752da3932
Author: Henry Nash <email address hidden>
Date: Tue Mar 24 08:58:32 2015 +0000

    Use correct LOG translation indicator for errors

    There was one place where we did not do use the _LE() indicator.

    Change-Id: I7f28cfe014b1053699116635020432c0f9ca2e87
    Partial-Bug: 1435693

Revision history for this message
Dolph Mathews (dolph) wrote :

Closing because all the cited violations have been fixed.

Henry: when you have a bug fix that consists of multiple patches, use Partial-Bug on all but the last patch in the sequence. On the last patch, use Closes-Bug so that the bug will be automatically closed when that patch merges.

Changed in keystone:
milestone: none → liberty-3
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/212596

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/212599

Revision history for this message
Dolph Mathews (dolph) wrote :

I thought this was backportable since it's only adding translation strings to stable/kilo (not modifying things that may have already been translated).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (stable/kilo)

Change abandoned by Dolph Mathews (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/212596
Reason: https://bugs.launchpad.net/keystone/+bug/1435693/comments/9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Dolph Mathews (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/212599
Reason: https://bugs.launchpad.net/keystone/+bug/1435693/comments/9

Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.