ec2 signature possible errors

Bug #1434599 reported by Dave Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Dave Chen

Bug Description

Beside the issue desribed in the bug#1289115, there are still other issues found with that piece of code, part of these issue has been confirmed with the original author.

something we need to fix:
- Check the colon from credentials['host'] instead of credentials['signature'].
- credentials['signature'] is not guaranteed to existed, so need to check it explicitly.
- Need reinitialize 'singer' to avoid contaminated status of signature.

Changed in keystone:
assignee: nobody → Dave Chen (wei-d-chen)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/143772
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7ace25e25fafef7809789dc3b799c1943a45301d
Submitter: Jenkins
Branch: master

commit 7ace25e25fafef7809789dc3b799c1943a45301d
Author: Dave Chen <email address hidden>
Date: Wed Dec 24 20:41:20 2014 +0800

    Fix errors in ec2 signature logic checking

    - Check for colon in credentials['host'] instead of
    credentials['signature'].
    - Fix the syntax issue when trying to get the signature
    from the dict.
    - credentials['signature'] is not guaranteed to existed,
    so check it explicitly.
    - Need to reinitialize 'signer' to avoid contaminated status
    of signature.

    Closes-Bug: #1289115
    Closes-Bug: #1434599
    Change-Id: Idb5d97c30a20872fdaafea786bcea2631d70858c

Changed in keystone:
status: In Progress → Fix Committed
summary: - some issue with ec2 signature
+ ec2 signature possible errors
Changed in keystone:
importance: Undecided → Medium
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.