Collapse Fernet specific tests into test_v3_auth.py TestAuth

Bug #1433331 reported by Lance Bragstad on 2015-03-17
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Lance Bragstad

Bug Description

When the Fernet token implementation landed, it was introduced with it's own testing layer [1]. These tests were designed to model the behavior specific to Fernet tokens. Fernet tokens should have the same V3 behavior as the rest of the token providers available in Keystone, which has been worked towards [2]. If the behavior is the same, then we should use the same tests with each provider. The TestFernetTokenProvider test cases should be analyzed and ported to TestAuth if not already there. Then we can leverage the work across all providers without having a bunch of tests that describe the same behavior for different providers.

[1] https://github.com/openstack/keystone/blob/3910931b464c143b3be38c39e70038498860a8bd/keystone/tests/unit/test_v3_auth.py#L4053
[2] https://review.openstack.org/#/c/164348/

description: updated
description: updated
tags: added: fernet test-improvement
Changed in keystone:
importance: Undecided → Low
tags: added: low-hanging-fruit
Dolph Mathews (dolph) on 2015-03-17
Changed in keystone:
status: New → Incomplete
status: Incomplete → Triaged
Changed in keystone:
milestone: none → kilo-rc1
Changed in keystone:
milestone: kilo-rc1 → none
Changed in keystone:
assignee: nobody → Jason O'Brien (jason10258)
Changed in keystone:
assignee: Jason O'Brien (jason10258) → nobody
jiaxi (tjxiter) on 2015-07-19
Changed in keystone:
assignee: nobody → jiaxi (tjxiter)
jiaxi (tjxiter) on 2015-07-19
Changed in keystone:
assignee: jiaxi (tjxiter) → nobody

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/167832
Reason: I still think this is important to have, but the token_provider API needs to be cleaned up before we can land this.

Changed in keystone:
assignee: nobody → Ron De Rose (ronald-de-rose)
Steve Martinelli (stevemar) wrote :

unassigning due to inactivity

Lance, is this still an issue?

Changed in keystone:
assignee: Ron De Rose (ronald-de-rose) → nobody
Lance Bragstad (lbragstad) wrote :

I think this can be closed now since a bunch of fixes landed to make fernet the default [0]. The TestFernetTokenProvider class has been refactored in master and no longer exists. It has been replaced with Fernet test classes that inherit tests from general test classes.

[0] https://review.openstack.org/#/q/status:merged+project:openstack/keystone+branch:master+topic:make-fernet-default

Changed in keystone:
status: Triaged → Won't Fix
status: Won't Fix → Fix Committed
Changed in keystone:
status: Fix Committed → Fix Released
assignee: nobody → Lance Bragstad (lbragstad)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers