href variables for federation controller are inconsistent

[Steve Martinelli]

For the most part, the href variables seen in JSON home requests for federation resources are consistent, https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/routers.py they are usually idp_id, sp_id, protocol_id and mapping_id.

Except for the following block:

  path=self._construct_url('identity_providers/{identity_provider}/'
                                      'protocols/{protocol}/auth'),

Where 'identity_provider' and 'protocol' are used instead of 'idp_id' and 'protocol_id'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157821

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/154321
Reason: meh

[Morgan Fainberg (mdrnstm)]

This cannot be fixed with the API contract we have. This will change the public interfaces. We cannot make changes to the public interfaces in this regard.

Marking as "wont fix"

[Dolph Mathews (dolph)]

I might be overlooking what you and Brant are referring to, but the proposed change does not seem to break any API contract.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Stanek (<email address hidden>) on branch: master
Review: https://review.openstack.org/157821
Reason: The bug was marked as Won't Fix

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/248312

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/248312
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=4f6cc67941f76eb7bcd079515b765b7d9b7e66ab
Submitter: Jenkins
Branch: master

commit 4f6cc67941f76eb7bcd079515b765b7d9b7e66ab
Author: Jamie Lennox <email address hidden>
Date: Sat Nov 21 11:55:09 2015 +1100

    Use idp_id and protocol_id in jsonhome

    These are inconsistent with the rest of the federation routes. Note that
    this doesn't change a public interface, it changes the path variables
    names that exist within a jsonhome document which should only be
    referenced within the same href_vars element and some internal variable
    names.

    Change-Id: I36d41e95d745bd98d36c3442bd4aa4faa91cab72
    Closes-Bug: #1420125

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/keystone 9.0.0.0b1 development milestone.