Testing of backend list_role_assignments needs to be improved

Bug #1415268 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Henry Nash

Bug Description

Although we have quite comprehensive testing of the various filter options on list_role_assignment at the controller level, we don;t have these at the backend manager level. This will become crucial since we are pushing the filtering down into the driver level AND will be rewriting many of the other assignment listing methods to simply call list_role_assignments.

https://github.com/openstack/keystone/blob/32d2267b2cfb004965505267b4e060a49e15c643/keystone/tests/test_backend.py
https://github.com/openstack/keystone/blob/1a9038925dec5acf803c338a5c494515d60e0323/keystone/tests/test_backend_ldap.py

Changed in keystone:
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/151623

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/151962

Changed in keystone:
milestone: kilo-2 → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/153897

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154302

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154485

Changed in keystone:
assignee: Henry Nash (henry-nash) → Samuel de Medeiros Queiroz (samueldmq)
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Since this is targeted to k-3, do the reviews listed in the comments need to be added to https://gist.github.com/dolph/651c6a1748f69637abd0

Changed in keystone:
milestone: kilo-3 → none
Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samueldmq) → Henry Nash (henry-nash)
Revision history for this message
Steve Martinelli (stevemar) wrote :

Marking this as fix released - all patches that were partial fixes have been merged and no new patches in 6 months.

Changed in keystone:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.