check whether V2 token is revoked has been performed twice

Bug #1414627 reported by Dave Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dave Chen

Bug Description

Check whether V2 token is revoked or not has been performed twice,

First check is here,
https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L247

Then in the func of _is_valid_token(token), the code check it again,
https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L357

This is unnecessary and has been removed in the validate_v3_token(self, token_id), need remove this code in validate_v2_token(...) as well.

Tags: performance
Dave Chen (wei-d-chen)
Changed in keystone:
assignee: nobody → Dave Chen (wei-d-chen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150022

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/150022
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=2c525a2a35cce99c60b96b79b110e20ac1106098
Submitter: Jenkins
Branch: master

commit 2c525a2a35cce99c60b96b79b110e20ac1106098
Author: Dave Chen <email address hidden>
Date: Tue Jan 27 04:51:30 2015 +0800

    Remove duplicate token revocation check

    Check whether V2 token is revoked has been performed twice, the first
    check is in the method of validate_v2_token(...), and then check in
    method _is_valid_token(...) again, remove the duplicated one.

    Change-Id: Iaffe6473f5277f10540d5e1647c69d282250becf
    Closes-Bug: #1414627

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
tags: added: performance
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.