Unnecessary conflict wrapper on assignment driver delete_project() method

[Henry Nash]

The assignment driver method delete_project [1] is protected by the sql.handle_conflicts wrapper - but that wrapper doesn't do anything for the delete case - and we don't use it for any other delete_entity() method other than project. We should remove this wrapper protection.

https://github.com/openstack/keystone/blob/f468f32d8f5fa3f01799e5ad3022eb8e065dc32a/keystone/resource/backends/sql.py#L164

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/247017

[Samuel de Medeiros Queiroz (samueldmq)]

In the regard of wrapping DB duplicate entry exceptions [1], it really doesn't do anything for delete. However, it also wraps any other DB exception (eg IntegrityError) into a HTTP 500 UnexpectedError with a custom message.

In my opinion it is worth it to keep this, and even add to any other methods that still don't have it.
Creating another wrapper only containing [2] may be a better option, making it clearer.

[1] https://github.com/openstack/keystone/blob/master/keystone/common/sql/core.py#L437-L444

[2] https://github.com/openstack/keystone/blob/master/keystone/common/sql/core.py#L445-L461

[Sean Perry (sean-perry-a)]

@samueldmq, the lines you refer to in sql/core.py are no longer present. What were you trying to say would be best practice?

[Samuel de Medeiros Queiroz (samueldmq)]

Hi Sean,

Updated links:

[1] https://github.com/openstack/keystone/blob/9535c09/keystone/common/sql/core.py#L406-L413
[2] https://github.com/openstack/keystone/blob/9535c09/keystone/common/sql/core.py#L414-L431

[Steve Martinelli (stevemar)]

Automatically unassigning due to inactivity.

[Adam Young (ayoung)]

Not a bugf, leave the wrapper in for SQL message reporting.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/247017
Reason: no action in 5 months and bug is marked as invalid, auto-abandoning