Status code from HEAD requests must be consistent

Bug #1402339 reported by Samuel de Medeiros Queiroz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Low
Unassigned

Bug Description

Bug 'HEAD and GET inconsistencies in Keystone' [1] reported that HEAD should be identical to GET except that there is no body returned, as defined on the HTTP 1.1 specification [2], then 200 status code have to be returned [3].

Some inconsistencies were removed, but there is still some work to be done:

1) For all HEAD/GET APIs:
   a) Fix return from 204 to 200, if change applies;
   b) Fix related tests, e.g checking a grant [4];
   c) Fix identity v3 API specification, that reports 204 is returned on most of HEAD APIs (except for /auth/tokens).
2) Default status code asserted on test_v3 [5] should be 200 instead of 204

[1] https://bugs.launchpad.net/keystone/+bug/1334368
[2] http://tools.ietf.org/html/rfc2616#section-9.4
[3] http://tools.ietf.org/html/rfc2616#section-10.2.1
[4] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3_assignment.py#L881
[5] https://github.com/openstack/keystone/blob/master/keystone/tests/test_v3.py#L479

Changed in keystone:
assignee: nobody → Samuel de Medeiros Queiroz (samuel-z)
description: updated
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone-specs (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142065

Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samuel-z) → Rodrigo Duarte (rodrigodsousa)
status: Triaged → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone-specs (master)

Change abandoned by Rodrigo Duarte (<email address hidden>) on branch: master
Review: https://review.openstack.org/142065
Reason: Not a bug, HEAD and GET returns the same status code:

$ curl -i -H "X-Auth-Token: $TOKEN" http://localhost:5000/v3/OS-INHERIT/domains/default/users/$USER_ID/roles/$ROLE_ID/inherited_to_projects
HTTP/1.1 204 No Content

$ curl -i -I -H "X-Auth-Token: $TOKEN" http://localhost:5000/v3/OS-INHERIT/domains/default/users/$USER_ID/roles/$ROLE_ID/inherited_to_projects
HTTP/1.1 204 No Content

$ curl -i -X HEAD -H "X-Auth-Token: $TOKEN" http://localhost:5000/v3/OS-INHERIT/domains/default/users/$USER_ID/roles/$ROLE_ID/inherited_to_projects
HTTP/1.1 204 No Content

Changed in keystone:
milestone: none → kilo-rc1
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Is this still a bug, or can it be moved from "In Progress" since the review was abandon?

Changed in keystone:
milestone: kilo-rc1 → none
tags: added: kilo-rc-potential
Changed in keystone:
assignee: Rodrigo Duarte (rodrigodsousa) → nobody
status: In Progress → Triaged
tags: removed: kilo-rc-potential
Kent Wang (k.wang)
Changed in keystone:
assignee: nobody → Kent Wang (k.wang)
Kent Wang (k.wang)
Changed in keystone:
assignee: Kent Wang (k.wang) → nobody
Revision history for this message
Steve Martinelli (stevemar) wrote :

no movement in over a year, only patch is abandoned

Changed in keystone:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.