check and delete policy_association_for_region_and_service performs create

[Adam Young]

In http://git.openstack.org/cgit/openstack/keystone/tree/keystone/contrib/endpoint_policy/controllers.py#n133

.create_policy_association should be check_policy_association

 @controller.protected()
    def check_policy_association_for_region_and_service(
            self, context, policy_id, service_id, region_id):
        """Check an association between a policy and region+service."""
        self.policy_api.get_policy(policy_id)
        self.catalog_api.get_service(service_id)
        self.catalog_api.get_region(region_id)
        self.endpoint_policy_api.create_policy_association(
            policy_id, service_id=service_id, region_id=region_id)

create_policy_association( should be delete_policy_association(

    @controller.protected()
    def delete_policy_association_for_region_and_service(
            self, context, policy_id, service_id, region_id):
        """Delete an association between a policy and region+service."""
        self.policy_api.get_policy(policy_id)
        self.catalog_api.get_service(service_id)
        self.catalog_api.get_region(region_id)
        self.endpoint_policy_api.create_policy_association(
            policy_id, service_id=service_id, region_id=region_id)

[Morgan Fainberg (mdrnstm)]

This also needs a hard look at tests to make sure we're *actually* testing this as well. We obviously are not.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/140122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/140122
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=1c615db7f2b3c29d58cfbd03e497a1e4b55cbb78
Submitter: Jenkins
Branch: master

commit 1c615db7f2b3c29d58cfbd03e497a1e4b55cbb78
Author: Adam Young <email address hidden>
Date: Mon Dec 8 14:12:24 2014 -0500

    Check and delete for policy_association_for_region_and_service

    Calls proper function in the manager and driver

    Unit tests now check pre- and post- conditions on CRUD

    Change-Id: I26e4d4f15ff39dd76141aa5fb7aae1ebb6680bf7
    Closes-bug: 1400362