Duplicate code in test_v3_federation

Bug #1389623 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Lance Bragstad

Bug Description

In the set set up of sample data, there exists the following:

        self.TOKEN_SCOPE_DOMAIN_B_FROM_CUSTOMER = self._scope_request(
            self.tokens['CUSTOMER_ASSERTION'], 'domain', self.domainB['id'])

        self.TOKEN_SCOPE_DOMAIN_B_FROM_CUSTOMER = self._scope_request(
            self.tokens['CUSTOMER_ASSERTION'], 'domain',
            self.domainB['id']

The second statement is a duplicate of the first (formatting aside).

Henry Nash (henry-nash)
Changed in keystone:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → Low
assignee: nobody → Henry Nash (henry-nash)
status: Triaged → New
tags: added: test-improvement
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133158

Changed in keystone:
assignee: Henry Nash (henry-nash) → Lance Bragstad (lbragstad)
status: New → In Progress
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Hey Henry,

I'm waiting for a few more people to show up to the "meetup" day at the Summit and figured I'd push a quick patch for this.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/133158
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=070ae05995c8ef057b4b72d815c21983d8b6fcf5
Submitter: Jenkins
Branch: master

commit 070ae05995c8ef057b4b72d815c21983d8b6fcf5
Author: Lance Bragstad <email address hidden>
Date: Fri Nov 7 02:24:39 2014 -0600

    Remove duplicate setup logic in federation tests

    This commit removes some duplicate setup logic for the federation test
    cases.

    Change-Id: I8886a83ffa8100af95d5cd877e8adacc9d38bbd6
    Closes-Bug: #1389623

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (feature/hierarchical-multitenancy)

Fix proposed to branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (feature/hierarchical-multitenancy)

Change abandoned by Morgan Fainberg (<email address hidden>) on branch: feature/hierarchical-multitenancy
Review: https://review.openstack.org/138182

Changed in keystone:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.