Add test for grant CRUD on test_backend

Bug #1367480 reported by Samuel de Medeiros Queiroz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Low
Samuel de Medeiros Queiroz

Bug Description

The fact of not having tests for this may cause some bugs.
For example, in KVS backend we call a non existent method and it would be avoided if we had such tests. [1]

[1] https://github.com/openstack/keystone/blame/master/keystone/assignment/backends/kvs.py#L512

Changed in keystone:
assignee: nobody → Samuel de Medeiros Queiroz (samuel-z)
description: updated
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Samuel, if you wanted the test to be kvs specific, you could consider adding it here:

https://github.com/openstack/keystone/blob/master/keystone/tests/test_backend_kvs.py

tags: added: test-improvement
Revision history for this message
Samuel de Medeiros Queiroz (samueldmq) wrote :

Lance, actually I really would like to add on test_backend so every backend would be tested, not only KVS.

Revision history for this message
Lance Bragstad (lbragstad) wrote :

Samuel,

Correct, in that case you could add it to test_backend.py

Changed in keystone:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/123590

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Samuel de Medeiros Queiroz (<email address hidden>) on branch: master
Review: https://review.openstack.org/123590

Revision history for this message
Steve Martinelli (stevemar) wrote :

i think the testing here is sufficient https://github.com/openstack/keystone/blob/5de11025f45ca10d2b02b70234c1305fae91766c/keystone/tests/unit/test_backend.py#L1101-L1148 and covers a lot of what was in the abandoned patch

Changed in keystone:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.