mapping engine ignores multiple assertion values when using regex

Bug #1321536 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Steve Martinelli

Bug Description

Previously, if the mapping engine saw a regex value, it would only compare the first "mapping value" and the first "assertion value".

For instance, if the mapping value was from the ".*tester*" and the assertion values were ['developer','tester','deployer'] it will fail the mapping check.

The solution would be to actually iterate over the assertion values until no match is found.

Tags: federation
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/94518

Changed in keystone:
assignee: nobody → Steve Martinelli (stevemar)
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
tags: added: federation
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/94518
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=713ddcf0b38a4460368a8c523260b4a48bd98ce9
Submitter: Jenkins
Branch: master

commit 713ddcf0b38a4460368a8c523260b4a48bd98ce9
Author: Steve Martinelli <email address hidden>
Date: Tue May 20 22:58:29 2014 -0400

    Mapping engine does not handle regex properly

    Currently, if there is more than one assertion value (the list of
    group ids returned from the idp). Then when using regex to compare
    again the mapping values, only the first values are used.

    Change-Id: Iba7d455ef0d5fc2d4ac16f4a7eb553845270fb2c
    Closes-Bug: #1321536

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.