Move code in ldap which delete elements of tree to common method
Bug #1316128 reported by
Sergey Nikitin
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Identity (keystone) |
Fix Released
|
Low
|
Sergey Nikitin | ||
Bug Description
Code which uses 'search_s' and 'delete_s' in ldap backends should be moved to a new method to remove duplication of code.
Also should be added handling of ldap.NO_SUCH_OBJECT exception because now it's just ignored.
| Changed in keystone: | |
| assignee: | nobody → Sergey Nikitin (snikitin) |
| Changed in keystone: | |
| status: | New → In Progress |
| tags: | added: ldap |
| Changed in keystone: | |
| importance: | Undecided → Low |
| Changed in keystone: | |
| assignee: | Sergey Nikitin (snikitin) → David Stanek (dstanek) |
| Changed in keystone: | |
| assignee: | David Stanek (dstanek) → Sergey Nikitin (snikitin) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to keystone (master) | #1 |
| Changed in keystone: | |
| status: | In Progress → Fix Committed |
| Changed in keystone: | |
| milestone: | none → juno-1 |
| status: | Fix Committed → Fix Released |
| Changed in keystone: | |
| milestone: | juno-1 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0f04648b4cb5aac
Author: Sergey Nikitin <email address hidden>
Date: Thu Apr 10 16:38:39 2014 +0400
Code which gets and deletes elements of tree was moved to one method
Code which uses 'search_s' and 'delete_s' in ldap backends was moved
to a new method to remove duplication of code.
Added handling of exception ldap.NO_SUCH_OBJECT when we couldn't
find a search base while deleting. Now this exception is
not ignored. Instead of this raised NotFound exception
or more suitable (RoleNotFound, etc).
Also added handling of situation when we trying to delete
nonexisting entries.
Closes-Bug: #1316128
Change-Id: I8e7402337ab4d7