keystone tests fail unless tox is configured "just so"

Bug #1310768 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Doug Hellmann

Bug Description

As discussed on IRC:

[Mon 03:49:43 PM] <dhellmann> I'm trying to package keystone from master, and run the tests. In order to run the tests in the virtualenv I'm creating, I change tox.ini to set a couple of variables differently: http://paste.openstack.org/show/76559/
[Mon 03:49:50 PM] <dhellmann> morganfainberg: yeah
[Mon 03:50:02 PM] <dhellmann> it seems that setting usedevelop=False breaks that function
[Mon 03:50:14 PM] <morganfainberg> oh oh i see how it could.
[Mon 03:50:15 PM] <morganfainberg> doh*
[Mon 03:50:41 PM] <dhellmann> because it finds a path for the module with a full path, and the / becomes a . and then import complains that '.home.whatever.some.long.path' has an empty module name
[Mon 03:50:45 PM] <dhellmann> at the front there
[Mon 03:51:33 PM] <dhellmann> morganfainberg: so we could fix it a couple of ways, either by doing more smart work with the paths, or by converting those modules to be loaded with stevedore
[Mon 03:51:44 PM] <dhellmann> morganfainberg: before I submit a patch, I thought I'd see which you all would prefer
[Mon 03:51:47 PM] <morganfainberg> dhellmann, the latter would be better
[Mon 03:52:15 PM] <morganfainberg> dhellmann, i would rather use stevedore for all of our backends eventually, it makes sense that the tests should be the same
[Mon 03:52:16 PM] <dhellmann> ok, I concur, but didn't know if there was some reason it was done this way to begin with
[Mon 03:52:38 PM] <morganfainberg> dhellmann, we haven't converted stuff to stevedore yet, afaict that is the reason

Changed in keystone:
assignee: nobody → Doug Hellmann (doug-hellmann)
Changed in keystone:
status: New → Triaged
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89419

Changed in keystone:
status: Triaged → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/90173
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=2865f20c70c9f95066008ee18b0862b43d916c04
Submitter: Jenkins
Branch: master

commit 2865f20c70c9f95066008ee18b0862b43d916c04
Author: Morgan Fainberg <email address hidden>
Date: Thu Apr 24 10:51:41 2014 -0700

    Fix the "search for sql.py" files for db models

    Fix the search logic for sql.py files for the db model import so
    that reflection created schemas are consistent.

    This does not mitigate the need to move to stevedore in the future
    for loading of backends / tests, but does solve the immidiate problem.

    Change-Id: If53bfb351d679e3309393c7d594942c55daff3a6
    Closes-Bug: #1310768

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Doug Hellmann (<email address hidden>) on branch: master
Review: https://review.openstack.org/89419

Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.