keystone-manage ssl_setup does not overwrite existing files

[Bill Lubanovic]

If you run "keystone-manage ssl_setup" more than once, it does not overwrite existing files under /etc/keystone/ssl, and does not print or log an error message.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88207

[David Stanek (dstanek)]

We should definitely be printing out a list of files that would need to be removed so that they can be replaced. I'm not sure I like the idea of having the script doing the deleting. It seems like it would be easy to make mistakes and we are not a configuration management tool.

It's also important to note that we'll be discouraging the use of pkg_setup in a future commit. https://review.openstack.org/#/c/80819/

[Adam Young (ayoung)]

On 04/21/2014 12:07 PM, David Stanek wrote:
> We should definitely be printing out a list of files that would need to
> be removed so that they can be replaced. I'm not sure I like the idea of
> having the script doing the deleting. It seems like it would be easy to
> make mistakes and we are not a configuration management tool.
>
> It's also important to note that we'll be discouraging the use of
> pkg_setup in a future commit. https://review.openstack.org/#/c/80819/
>
We should not be using keystone_manage ssl: it is only for a
development setup. In a real setup, you need real certificates.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/88207
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cc3e2355eac51d92f1436704f1873554b11e2da2
Submitter: Jenkins
Branch: master

commit cc3e2355eac51d92f1436704f1873554b11e2da2
Author: wanghong <email address hidden>
Date: Thu Apr 17 16:05:51 2014 +0800

    add --rebuild option for ssl/pki_setup

    Currently, if you run "keystone-manage ssl_setup" more than once,
    it does not overwrite existing files under /etc/keystone/ssl, and
    does not print or log an error message. Now, we add --rebuild option
    for ssl/pki_setup to clean up the exist generated files and rebuild
    the configure files. Also, if you run "keystone-manage ssl_setup"
    more than once, it will print prompt message to tell you take
    --rebuild option to rebuild configure files.

    Change-Id: Ia1e6830c4c81d5a53317a522c526b79b67de1bce
    Closes-Bug: #1308778