TrustNotFound exceptions not setting trust_id kwarg in trustv3 controller

Bug #1305272 reported by Morgan Fainberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Priti Desai

Bug Description

The Trustv3 controller is not setting trust_id=trust_id when raising TrustNotFound exceptions, it is passing the trust_id as the message, causing a non-descriptive message to be passed through the API.

Changed in keystone:
status: New → Triaged
importance: Undecided → Low
Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: Triaged → In Progress
Changed in keystone:
assignee: Morgan Fainberg (mdrnstm) → Priti Desai (priti-desai)
Revision history for this message
Priti Desai (priti-desai) wrote :

Fix submitted to branch: Master
Review: https://review.openstack.org/#/c/86187/

Thanks Morgan !

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/86187
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=da4d4a1035b688bbb7e7065c792b29978bfafc1f
Submitter: Jenkins
Branch: master

commit da4d4a1035b688bbb7e7065c792b29978bfafc1f
Author: Priti Desai <email address hidden>
Date: Tue Apr 8 23:02:59 2014 +0000

    Adding more descriptive error message

    Keystone Trusts API sends non descriptive error message for requests with
    invalid trust id.
    The error message only contains invalid_trust_id instead of printing:
    "Could not find trust: invalid_trust_id"
    Setting kwarg "trust_id" in the exception.

    Closes-Bug: #1305272
    Change-Id: I35cab35ab90cf66ce7124dea142013bec9eefda9

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/87406

Dolph Mathews (dolph)
tags: added: havana-backport-potential
tags: added: icehouse-rc-potential
Thierry Carrez (ttx)
tags: added: icehouse-backport-potential
removed: icehouse-rc-potential
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (stable/havana)

Change abandoned by Dolph Mathews (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/87406
Reason: stable/havana is now security-fixes-only

Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.