remove hardcoded SQL queries in tests

Bug #1287637 reported by Matthieu Huin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
wanghong

Bug Description

There are several occurrences of hardcoded SQL queries at least in test_sql_upgrade.py:

* https://github.com/openstack/keystone/blob/master/keystone/tests/test_sql_upgrade.py#L941
* https://github.com/openstack/keystone/blob/master/keystone/tests/test_sql_upgrade.py#L946

Due to variations in databases these queries might not work all the time, and should be replaced by queries built with sqlalchemy.

A code sweep is in order to find and replace any hardcoded queries.

Dolph Mathews (dolph)
Changed in keystone:
status: New → Triaged
importance: Undecided → Low
summary: - remove hardcoded SQL queries
+ remove hardcoded SQL queries in tests
tags: added: low-hanging-fruit
wanghong (w-wanghong)
Changed in keystone:
assignee: nobody → wanghong (w-wanghong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79296

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/79296
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cb8d6486eb5b14a5de45588b854908bd58fe984f
Submitter: Jenkins
Branch: master

commit cb8d6486eb5b14a5de45588b854908bd58fe984f
Author: wanghong <email address hidden>
Date: Mon Mar 10 19:53:50 2014 +0800

    remove hardcoded SQL queries in tests

    There are several occurrences of hardcoded SQL queries in tests.
    Due to variations in databases these queries might not work all
    the time, and should be replaced by queries built with sqlalchemy.

    Change-Id: Id0198ea03087ab4acc7eebf0e4d12a37e3437382
    Closes-Bug: #1287637

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.