Attempt to call strftime on a str fails revocation_list

[Steve Baker]

This causes heat authenticated operations to fail for me locally

2014-02-28 10:25:10.084 ERROR keystone.common.wsgi [-] 'str' object has no attribute 'strftime'
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi Traceback (most recent call last):
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi File "/home/steveb/dev/localstack/keystone/keystone/common/wsgi.py", line 211, in __call__
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi result = method(context, **params)
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi File "/home/steveb/dev/localstack/keystone/keystone/openstack/common/versionutils.py", line 102, in wrapped
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi return func(*args, **kwargs)
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi File "/home/steveb/dev/localstack/keystone/keystone/common/controller.py", line 131, in inner
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi return f(self, context, *args, **kwargs)
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi File "/home/steveb/dev/localstack/keystone/keystone/token/controllers.py", line 423, in revocation_list
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi t['expires'] = timeutils.isotime(expires)
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi File "/home/steveb/dev/localstack/keystone/keystone/openstack/common/timeutils.py", line 38, in isotime
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi st = at.strftime(_ISO8601_TIME_FORMAT
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi AttributeError: 'str' object has no attribute 'strftime'
2014-02-28 10:25:10.084 TRACE keystone.common.wsgi

Possibly the six.text_type check should be six.string_types, but actually that conditional should really be checking for isinstance datetime.datetime explicitly, since that is what timeutils.isotime is assuming.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76977

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76977
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a6840be9ac09cca334a37b8ab84c71679581d45e
Submitter: Jenkins
Branch: master

commit a6840be9ac09cca334a37b8ab84c71679581d45e
Author: Steve Baker <email address hidden>
Date: Fri Feb 28 10:29:12 2014 +1300

    revocation_list only call isotime on datetime objects

    If expires is a str then isinstance six.text_type is false then the following
    exception is raised:
    AttributeError: 'str' object has no attribute 'strftime'

    This change explicitly checks for a datetime object, which is what
    timeutils.isotime expects.

    Change-Id: I8012f96498fffe5f54e7f1ca08b7beb6fa168f9c
    Closes-Bug: #1285871

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/235487

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Stanek (<email address hidden>) on branch: master
Review: https://review.openstack.org/235487
Reason: No activity. If anyone wants to work on this, fell free to re-open.