Downgrade of assignment to grant tables has issues with postgresql & mysql

Bug #1284700 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Critical
Henry Nash

Bug Description

There are two issues:

1) The downgrade on Mysql may fail due to not committing changes at the appropriate time when there are multiple assignment entries being mapped back into a single grant entry. This works fine with postgresql (appears to an sqlalchemy issue)

2) test_sql_upgrade fails to close an outer session that has done a SELECT on the grant tables we want to drop - which will cause the drop to block on databases other the sqllite. This doesn't affect a production migration, but stops the tests.

Henry Nash (henry-nash)
description: updated
Henry Nash (henry-nash)
Changed in keystone:
importance: High → Critical
summary: - test_sql_upgrade fails to drop old grant tables on postgresql
+ Downgrade of assignment to grant tables has issues with postgresql &
+ mysql
description: updated
description: updated
Henry Nash (henry-nash)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76341

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/76341
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=4d505e63902bd31e40904a0c9045b9b07d5bdb5a
Submitter: Jenkins
Branch: master

commit 4d505e63902bd31e40904a0c9045b9b07d5bdb5a
Author: Henry Nash <email address hidden>
Date: Tue Feb 25 17:51:43 2014 +0000

    Fix issue with DB upgrade to assignment table

    There are two changes:
    - Commit changes to the grant tables after each update to ensure MySQL
      doesn't get confused when there are multiple assignments for a given
      actor/target (Postgresql doesn't have this issue)
    - Close any sessions in test_sql_upgarde before we call the migrations,
      to ensure table dropping won't be blocked

    Fixes bug 1284700

    Change-Id: I81704b17ea9c11be926018df125fcfdb79ee6271

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.