Policy testing checks could be simplified in test_v3_filters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Identity (keystone) |
Fix Released
|
Wishlist
|
Adam Young |
Bug Description
test_v3_filters resets the policy file repeatedly to perform its various checks. Usinf the current code, if you do this within a given test more than once it seems to break, leading to more complex test code. E.g.:
# TODO(henry-nash) Ideally the policy setting would happen in the
# entity for-loop below, using a string substitution of 'plural'.
# However, that appears to lead to unreliable policy checking - i.e.
# multiple calls to _set_policy doesn't work properly.
for entity in ['user', 'group', 'project']:
Do some action that needs the policy above for that type of entity
whereas it would be better to reset the policy every time in the loop.
Changed in keystone: | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
tags: | added: test-improvement |
Changed in keystone: | |
assignee: | nobody → Konstantin Maximov (konstantin-maximov) |
Changed in keystone: | |
status: | Triaged → In Progress |
Changed in keystone: | |
assignee: | Konstantin Maximov (konstantin-maximov) → Adam Young (ayoung) |
Changed in keystone: | |
milestone: | none → kilo-rc1 |
status: | Fix Committed → Fix Released |
Changed in keystone: | |
milestone: | kilo-rc1 → 2015.1.0 |
Fix proposed to branch: master /review. openstack. org/156597
Review: https:/