Changing cache_time doesn't work

Bug #1265670 reported by Brant Knudson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Brant Knudson

Bug Description

The [assignment].cache_time value is loaded at import-time. This means that it gets the default value rather than the value that the user configured because the user config isn't read until CONF() is called (in keystone-all).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64758

Changed in keystone:
assignee: nobody → Brant Knudson (blk-u)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/64759

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/64758
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5e7b4809aa81fc8c7d381a6ac95730b0f10edc1e
Submitter: Jenkins
Branch: master

commit 5e7b4809aa81fc8c7d381a6ac95730b0f10edc1e
Author: Brant Knudson <email address hidden>
Date: Thu Jan 2 18:42:42 2014 -0600

    Fix reading cache-time before configured

    There were several places where the cache time was read at
    import-time. This means that the default value is used rather
    than the value that the user configured because CONF() had not
    been called yet.

    This change makes it so the values are read at run-time, after
    CONF() has been called.

    Change-Id: I835418f249c5217bf79efebad1dee22d25f6774a
    Closes-Bug: #1265670

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/64759
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d542caa47eae3d7321c8d7bcf17c26e5dce08713
Submitter: Jenkins
Branch: master

commit d542caa47eae3d7321c8d7bcf17c26e5dce08713
Author: Brant Knudson <email address hidden>
Date: Thu Jan 2 18:44:47 2014 -0600

    Don't configure on import

    The keystone.config package called config.configure() at import-
    time.

    This will make it obvious that developers can't use config
    options at import-time because packages that do that will fail on
    import.

    Change-Id: I9306f67609d782e3f49fd43908448daf1287d51c
    Related-Bug: #1265108
    Related-Bug: #1265670
    Closes-Bug: #1269785

Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.