keystone endpoint-create default region

Bug #1252299 reported by Olivier Buisson
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Unassigned
python-keystoneclient
Won't Fix
Low
Unassigned

Bug Description

Hello,

When creating new endpoint without "--region" flag, the default region is set to 'regionOne'. But glance client and other services seems to use "RegionOne"

It will be better to change the default region from 'regionOne' to 'RegionOne'. See the patch of keystoneclient/v2_0/shell.py attach to correct the bug.

Revision history for this message
Olivier Buisson (obuisson) wrote :
description: updated
Revision history for this message
Dolph Mathews (dolph) wrote :

"regionOne" appears throughout keystone's examples and in keystoneclient/v2_0/shell.py -- we should definitely standardize on a specific default value here.

Changed in keystone:
importance: Undecided → Low
Dolph Mathews (dolph)
tags: added: low-hanging-fruit
Changed in keystone:
assignee: nobody → anusha rayani (anusha-rayani-7)
Revision history for this message
anusha rayani (anusha-rayani-7) wrote :

Yes agree, we should standardize on a specific default value. Please let us know if this is a confirmed bug so that we could propose the trivial code changes for this.

Thanks.

Revision history for this message
Dolph Mathews (dolph) wrote :

Sure, but it's more than just a one line change. PKI examples also use 'regionOne' so they should be revised and new examples generated. This is also a smaller issue in keystone, and in the tests of both projects.

Changed in python-keystoneclient:
importance: Undecided → Low
Changed in python-keystoneclient:
assignee: nobody → anusha rayani (anusha-rayani-7)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60338

Changed in keystone:
status: New → In Progress
Changed in python-keystoneclient:
status: New → In Progress
Wei Wang (damon-devops)
Changed in keystone:
assignee: anusha rayani (anusha-rayani-7) → Wei Wang (damon-devops)
Changed in python-keystoneclient:
assignee: anusha rayani (anusha-rayani-7) → Wei Wang (damon-devops)
Revision history for this message
Wei Wang (damon-devops) wrote :

Need to be fixed:

## keystone:
keystone/tests/test_catalog.py

keystone/examples/pki/cms/auth_token_scoped.json
keystone/examples/pki/cms/auth_token_revoked.json

## keystoneclient:

keystoneclient/tests/v2_0/test_shell.py
keystoneclient/v2_0/shell.py

keystoneclient/examples/pki/cms/auth_token_scoped.json
keystoneclient/examples/pki/cms/auth_token_scoped_expired.json
keystoneclient/examples/pki/cms/auth_v3_token_scoped.json
keystoneclient/examples/pki/cms/auth_token_revoked.json
keystoneclient/examples/pki/cms/auth_v3_token_revoked.json

Revision history for this message
Wei Wang (damon-devops) wrote :

Change has been successfully merged into the git repository.
Patch upload by Dolph Mathews.
See at https://review.openstack.org/#/c/60338/

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
Dolph Mathews (dolph) wrote :

"Fix Released" indicates that the change has been released in a milestone, whereas "Fix Committed" simply indicates the patch has been merged to the relevant branch (master, in this case).

Changed in keystone:
status: Fix Released → Fix Committed
Revision history for this message
Wei Wang (damon-devops) wrote :

@Dolph
Thanks for correcting my mistake, the patch to client has no one to review (https://review.openstack.org/#/c/71012/), could you please give me some advice?

Revision history for this message
Wei Wang (damon-devops) wrote :

In the patch at https://review.openstack.org/#/c/71012/

@Jamie and @Brant, bringed their concern which I think is necessary.

Jamie's review comment:

"Does it constitute a change in compatibility if we change the default region. If i have a script and i create a new endpoint then when searching for endpoints with regionOne later it will no longer work.

"Having it changed on the server is actually easier than the client because we promise our users that we aren't going to change the way things currently work. "

Maybe we need to consider more on this bug.

Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
Wei Wang (damon-devops)
Changed in python-keystoneclient:
assignee: Wei Wang (damon-devops) → nobody
Changed in keystone:
assignee: Wei Wang (damon-devops) → nobody
Revision history for this message
Steve Martinelli (stevemar) wrote :

so the CLI still defaults to 'regionOne', but it's deprecated in favor of openstackclient.

openstackclient, and the python bindings in keystoneclient do not default region name to anything and let the server handle the default name (RegionOne), so there is nothing left to fix here, we won't be fixing deprecated code unless it's a security issue

Changed in python-keystoneclient:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers