keystone endpoint-create default region

[Olivier Buisson]

Hello,

When creating new endpoint without "--region" flag, the default region is set to 'regionOne'. But glance client and other services seems to use "RegionOne"

It will be better to change the default region from 'regionOne' to 'RegionOne'. See the patch of keystoneclient/v2_0/shell.py attach to correct the bug.

[Dolph Mathews (dolph)]

"regionOne" appears throughout keystone's examples and in keystoneclient/v2_0/shell.py -- we should definitely standardize on a specific default value here.

[anusha rayani (anusha-rayani-7)]

Yes agree, we should standardize on a specific default value. Please let us know if this is a confirmed bug so that we could propose the trivial code changes for this.

Thanks.

[Dolph Mathews (dolph)]

Sure, but it's more than just a one line change. PKI examples also use 'regionOne' so they should be revised and new examples generated. This is also a smaller issue in keystone, and in the tests of both projects.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60338

[Wei Wang (damon-devops)]

Need to be fixed:

## keystone:
keystone/tests/test_catalog.py

keystone/examples/pki/cms/auth_token_scoped.json
keystone/examples/pki/cms/auth_token_revoked.json

## keystoneclient:

keystoneclient/tests/v2_0/test_shell.py
keystoneclient/v2_0/shell.py

keystoneclient/examples/pki/cms/auth_token_scoped.json
keystoneclient/examples/pki/cms/auth_token_scoped_expired.json
keystoneclient/examples/pki/cms/auth_v3_token_scoped.json
keystoneclient/examples/pki/cms/auth_token_revoked.json
keystoneclient/examples/pki/cms/auth_v3_token_revoked.json

[Wei Wang (damon-devops)]

Change has been successfully merged into the git repository.
Patch upload by Dolph Mathews.
See at https://review.openstack.org/#/c/60338/

[Dolph Mathews (dolph)]

"Fix Released" indicates that the change has been released in a milestone, whereas "Fix Committed" simply indicates the patch has been merged to the relevant branch (master, in this case).

[Wei Wang (damon-devops)]

@Dolph
Thanks for correcting my mistake, the patch to client has no one to review (https://review.openstack.org/#/c/71012/), could you please give me some advice?

[Wei Wang (damon-devops)]

In the patch at https://review.openstack.org/#/c/71012/

@Jamie and @Brant, bringed their concern which I think is necessary.

Jamie's review comment:

"Does it constitute a change in compatibility if we change the default region. If i have a script and i create a new endpoint then when searching for endpoints with regionOne later it will no longer work.

"Having it changed on the server is actually easier than the client because we promise our users that we aren't going to change the way things currently work. "

Maybe we need to consider more on this bug.

[Steve Martinelli (stevemar)]

so the CLI still defaults to 'regionOne', but it's deprecated in favor of openstackclient.

openstackclient, and the python bindings in keystoneclient do not default region name to anything and let the server handle the default name (RegionOne), so there is nothing left to fix here, we won't be fixing deprecated code unless it's a security issue