Fix errors for create_endpoints in version2

[huangtianhua]

1. Create an endpoint without 'service_id' has thrown a 500 Internal Server Error.It should return a 400 Bad Request with appropriate message.
2. Invalid urls should be discarded in response body.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/56176

[Lance Bragstad (lbragstad)]

Could you list the steps you took to get the 500 error? I've tried passing an invalid service id and no service id, but I'm not getting the 500 error.

[Dolph Mathews (dolph)]

Reproduced:

POST http://localhost:35357/v2.0/endpoints

Content-Type: application/json
X-Auth-Token: ADMIN

{
  "endpoint": {
    "publicurl": "asdf"
  }
}

500 Internal Server Error
Date: Fri, 22 Nov 2013 16:07:14 GMT
Vary: X-Auth-Token
Content-Length: 156
Status: 500
Content-Type: application/json

{
  "error": {
    "message": "An unexpected error prevented the server from fulfilling your request. 'service_id'",
    "code": 500,
    "title": "Internal Server Error"
  }
}

[Dolph Mathews (dolph)]

I also tested this against v3, and a 400 is returned, as expected.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/57979

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57979
Committed: http://github.com/openstack/keystone/commit/e3b67d9129f41838943a34c26886863483d414f4
Submitter: Jenkins
Branch: master

commit e3b67d9129f41838943a34c26886863483d414f4
Author: Dolph Mathews <email address hidden>
Date: Fri Nov 22 10:58:05 2013 -0600

    refactor test_catalog

    - Tests for "missing" attributes are actually testing with null values,
      not missing keys.
    - Not being able to explicitly provide alternative URLs resulting in
      hacky workarounds that can be avoiding by simply exposing kwargs with
      reasonable defaults
    - Several tests redundantly asserted the expected response status, which
      is already handled by the test framework

    Change-Id: Icadb4927bcf03ca7e79fef1507e419a4932f32a9
    Related-Bug: 1250765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/56176
Committed: http://github.com/openstack/keystone/commit/dbd98a4c857411bf33184332724270c980c99f36
Submitter: Jenkins
Branch: master

commit dbd98a4c857411bf33184332724270c980c99f36
Author: huangtianhua <email address hidden>
Date: Wed Nov 13 18:05:22 2013 +0800

    Fix errors for create_endpoint api in version2

    1. Create an endpoint without 'service_id' should return a 400 Bad Request
    with appropriate message instead of 500 Internal Server Error.
    2. Empty urls should be discarded.

    Change-Id: I535467ec35fe2ae738ecae0a4f20d19ff4f001ec
    Closes-Bug: #1250765