examples/pki/cms/auth_token_unscoped.json does not parse

Bug #1249117 reported by Rick Hull
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Rick Hull

Bug Description

examples/pki/cms/auth_token_unscoped.json does not parse

Problems:
1. uses single quotes
2. has a trailing comma
3. no trailing newline

(3) is not a parse problem but some linters don't like it

I'll submit a fix shortly.

Revision history for this message
Rick Hull (rick-i) wrote :

noticed in grizzly

Changed in keystone:
assignee: nobody → Rick Hull (rick-i)
Revision history for this message
Rick Hull (rick-i) wrote :
Changed in keystone:
status: New → In Progress
Revision history for this message
Rick Hull (rick-i) wrote :

changed status to fix committed. i'm unsure of the local policies so feel free to revert. I've gotten a few +1s on the code review.

Changed in keystone:
status: In Progress → Fix Committed
description: updated
Revision history for this message
Thierry Carrez (ttx) wrote :

Bug should stay "in progress" until it's merged ("fix committed"). When it gets ito a milestone release it should be set automatically to "fix released".

Changed in keystone:
status: Fix Committed → In Progress
Revision history for this message
Rick Hull (rick-i) wrote :

Understood, thanks!

Revision history for this message
Dolph Mathews (dolph) wrote :

Thanks!

Changed in keystone:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/55600
Committed: http://github.com/openstack/keystone/commit/3f179e439107b6bde08361664bfa225e7726afd0
Submitter: Jenkins
Branch: master

commit 3f179e439107b6bde08361664bfa225e7726afd0
Author: Rick Hull <email address hidden>
Date: Thu Nov 7 22:32:25 2013 +0000

    fix unparseable JSON

    - use only double quotes
    - remove trailing commas for last element
    - add trailing newline

    Change-Id: I3f47a25cdac429d95319ca80c6622b9cb1460446
    Closes-Bug: #1249117

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers