034 migration fails for SQLite if there is data in the user table

Bug #1233329 reported by Morgan Fainberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Morgan Fainberg

Bug Description

Due to not closing the cursor on the table-wide select, SQLite migration fails for 034 if there is data in the user table.

Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: New → In Progress
Dolph Mathews (dolph)
tags: added: havana-backport-potential
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/48746
Committed: http://github.com/openstack/keystone/commit/c7cb51d5533ec15f9bf487da2e617b49e02d039b
Submitter: Jenkins
Branch: master

commit c7cb51d5533ec15f9bf487da2e617b49e02d039b
Author: Morgan Fainberg <email address hidden>
Date: Fri Sep 27 13:38:59 2013 -0700

    Close the cursor for SQLite for 034 upgrade/downgrade on select

    The list() is needed around the table select for SQLite upgrade/downgrade
    to work. This forces a cursor close and prevents database locked errors.

    closes-bug: 1233329
    Change-Id: I01aedf9d2743a86881c124c9690f10233d9966bc

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → havana-rc2
tags: removed: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (milestone-proposed)

Reviewed: https://review.openstack.org/50497
Committed: http://github.com/openstack/keystone/commit/d044f0bfed76f9bac0277fcd645b6f21eb088eaf
Submitter: Jenkins
Branch: milestone-proposed

commit d044f0bfed76f9bac0277fcd645b6f21eb088eaf
Author: Morgan Fainberg <email address hidden>
Date: Fri Sep 27 13:38:59 2013 -0700

    Close the cursor for SQLite for 034 upgrade/downgrade on select

    The list() is needed around the table select for SQLite upgrade/downgrade
    to work. This forces a cursor close and prevents database locked errors.

    closes-bug: 1233329
    Change-Id: I01aedf9d2743a86881c124c9690f10233d9966bc

Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.