the domain name is case insensitive with keystone v3

Bug #1229093 reported by hill
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
David Stanek

Bug Description

I found the domain name is case insensitive when i use keystone /v3/auth/tokens which means

i can use the "default", "deFault" as domain name to get the valid token.

When i checked the code , i found the keystone uses database query to get the domain by name , if my database

is mysql with default configuration then it is case insensitive, but the postgres is case sensitive by default.

This is not a consistent API behavior. I would like to get the same output no matter what kind of db in backend.

I propose to use case sensitive due to security reason.

hill (yuyuehill)
summary: - the domain name is insensitive with keystone v3
+ the domain name is case insensitive with keystone v3
Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
status: New → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :

I restored some old tests that illustrate keystone's intent to be case sensitive. On the MySQL side, you can certainly configure it to be case sensitive (e.g. using utf8_bin, although I'm not sure that the best solution?), so perhaps this is something we can address via migrations.

Changed in keystone:
importance: Undecided → Medium
Revision history for this message
Dolph Mathews (dolph) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/25713
Committed: http://github.com/openstack/keystone/commit/e33e6dbeb07f14a9c551da012be71d870f838834
Submitter: Jenkins
Branch: master

commit e33e6dbeb07f14a9c551da012be71d870f838834
Author: Dolph Mathews <email address hidden>
Date: Fri Mar 29 09:30:35 2013 -0500

    Test for backend case sensitivity

    Partial-Bug: 1229093
    Change-Id: I912f05de52842fa0e564764c440dd9621e05fcbc

Revision history for this message
Kurt Seifried (kseifried) wrote :

Does this need a CVE?

Revision history for this message
Dolph Mathews (dolph) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: Dolph Mathews (dolph) → nobody
Dolph Mathews (dolph)
Changed in keystone:
status: In Progress → Triaged
Changed in keystone:
assignee: nobody → Alexey Miroshkin (amirosh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/236103

Changed in keystone:
assignee: Alexey Miroshkin (amirosh) → Henrique Truta (henriquetruta)
status: Triaged → In Progress
Changed in keystone:
assignee: Henrique Truta (henriquetruta) → David Stanek (dstanek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/236103
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=33860b31fcbf7dc8a6ffdcbc1c0e131e652cdcff
Submitter: Jenkins
Branch: master

commit 33860b31fcbf7dc8a6ffdcbc1c0e131e652cdcff
Author: henriquetruta <email address hidden>
Date: Fri Oct 16 18:02:10 2015 -0300

    Improves domain name case sensitivity tests

    The old domain name case sensitivity test only tested if we were able to
    create a domain, but did not test the get_domain_by_name resource_api
    call case sensitivity

    Change-Id: I2df8611d4e4f983ad91b32c41168ffe2e082e532
    Closes-Bug: 1229093

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/keystone 9.0.0.0b3

This issue was fixed in the openstack/keystone 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.