Need use _() to handle i18n string messages

[YangLei]

Need use _() to handle the string message in file keystone/identity/controllers.py

On a non-english env (ja), we will see the english message strings, when we create or update a user with empty name or empty Enabled. In fact, we need the non-english (ja) messages.

And find the follow string messages in file keystone/identity/controllers.py:
            msg = 'Name field is required and cannot be empty'
                msg = 'Marker could not be found'
                msg = 'Invalid limit value'
            msg = 'Name field is required and cannot be empty'
            msg = 'Enabled field must be a boolean'
            msg = 'Enabled field should be a boolean'
            msg = 'Name field is required and cannot be empty'
            msg = 'Specify a domain or project, not both'
           msg = 'Specify a user or group, not both'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44997

[Lance Bragstad (lbragstad)]

YangLei can you give some steps on how you reproduced this?

[YangLei (yanglyy)]

find/search msg = ' in file keystone/identity/controllers.py
You will get the string message list which need to be handled with _().

[ZhiQiang Fan (aji-zqfan)]

can you fix all i18n problem in keystone, not just a single file?

[YangLei (yanglyy)]

I do not think someone can fix all i18n problem in one bug for keystone,
In that way, someone have to find all the i18n problem in keystone first. It is too difficult to find out all problem.

I just see the problem when do the follow actions:
Create or update a user with empty name or empty Enabled

[Dolph Mathews (dolph)]

Tracking any issue file by file would be ridiculous to keep up with.

String freeze for havana is today [1], so I'd suggest making as many improvements as you can under the same bug / patch.

[1]: https://wiki.openstack.org/wiki/Havana_Release_Schedule

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/44997
Committed: http://github.com/openstack/keystone/commit/4bfa58ddb80c8484ad510d65fd3760429e5f3c6c
Submitter: Jenkins
Branch: master

commit 4bfa58ddb80c8484ad510d65fd3760429e5f3c6c
Author: YangLei <email address hidden>
Date: Wed Sep 4 11:14:22 2013 +0800

    Need to use _() to handle i18n string messages

    Partial-Bug: #1220502
    Change-Id: If31dd659794743837e2e494a2b6ae4488ef6ca32

[Dolph Mathews (dolph)]

Unassigning due to inactivity.

[Morgan Fainberg (mdrnstm)]

It looks like this has been fixed for a while / no longer an issue. I'm going to mark this bug as invalid (cleaning up the bug tracker)