High numbers of revocation events cause excessive cache churn

Bug #1220359 reported by Morgan Fainberg on 2013-09-03
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Morgan Fainberg

Bug Description

Due to the explicit refresh on the revocation list cache, when a revocation event occurs there is an added extra load to the Keystone processes. This should be changed to an invalidate of cache to ensure that we do not have to regenerate the revocation_list except on actual demand. This reduces overall lock contention when using memcache / redis / external storage as the cache layer.

Changed in keystone:
importance: Undecided → Low
summary: - High revocation events cause excessive cache churn
+ High numbers of revocation events cause excessive cache churn

Fix proposed to branch: master
Review: https://review.openstack.org/45806

Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: New → In Progress
Dolph Mathews (dolph) on 2013-09-10
Changed in keystone:
milestone: none → havana-rc1

Reviewed: https://review.openstack.org/45806
Committed: http://github.com/openstack/keystone/commit/a9a1e1a4254c76f5f659af370dd6a1f1db1aac1a
Submitter: Jenkins
Branch: master

commit a9a1e1a4254c76f5f659af370dd6a1f1db1aac1a
Author: Morgan Fainberg <email address hidden>
Date: Mon Sep 9 19:10:01 2013 -0700

    Reduce churn of cache on revocation_list

    The explicit call to refresh will cause higher-than-average load
    under high counts of revocation events. The simple invalidate ensures
    that we don't re-generate the revocation list on revocation event
    but only on-demand.

    closes-bug: 1220359
    Change-Id: I826778843e344be001bbcc832054a0ad446285e7

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-10-02
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers