cleanup tests for keystone.common.cache

Bug #1218743 reported by Morgan Fainberg on 2013-08-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Morgan Fainberg

Bug Description

Cleanup and expand tests for keystone.common.cache to ensure all aspects are covered within the unit tests.

* The noop backend should have validation of methods
* Minor restructuring of the IsolationProxy to be more streamlined
* Add test to verify global toggle
* Add test to verify exception is raised when non-cache region is "configured"
* Validation of the debug proxy (data is not mangled in use).

Changed in keystone:
assignee: nobody → Morgan Fainberg (mdrnstm)
importance: Undecided → Low

Fix proposed to branch: master
Review: https://review.openstack.org/44408

Changed in keystone:
status: New → In Progress

Reviewed: https://review.openstack.org/44408
Committed: http://github.com/openstack/keystone/commit/90881278a11e4c6e6bd10cf07d3749c2491c5faf
Submitter: Jenkins
Branch: master

commit 90881278a11e4c6e6bd10cf07d3749c2491c5faf
Author: Morgan Fainberg <email address hidden>
Date: Thu Aug 29 23:13:52 2013 -0700

    Cleanup cache layer tests

    Simple cleanup of keystone/tests/test_cache.py. Added the following
    tests:

    * Global Should Cache Toggle
    * Configure Non-CacheRegion object raises Validation Error
    * Cache Debug Proxy doesn't mangle data / raise exceptions
    * Cache Noop Backend, in-fact, does nothing.

    Isolation proxy un-used methods removed.

    closes-bug: 1218743
    Change-Id: Id980a9bff554c72a02461cecbcb533466225a701

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in keystone:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers