conusmer create in sql, description should be nullable

Bug #1215482 reported by Steve Martinelli on 2013-08-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
yong sheng gong

Bug Description

when playing around with openstack client:
$ openstack consumer create
ERROR: cliff.app An unexpected error prevented the server from fulfilling your request. (OperationalError) (1048, "Column 'description' cannot be null") 'INSERT INTO consumer (id, description, secret, extra) VALUES (%s, %s, %s, %s)' ('0ab66a011274424e9cfd4564809e645c', None, '89382f383c864257ab6620d27f792696', '{}') (HTTP 500)

In keystone/contrib/oauth/backends/sql, I noticed that:
description = sql.Column(sql.String(64), nullable=False)

This should be nullable=True, we would also need a new migration file too.

yong sheng gong (gongysh) wrote :

Hi Steve Martinelli,
The patch https://review.openstack.org/#/c/43237/ is approved when I see your comment. So I am afraid we have to create a 003.
Regards,
Yong Sheng Gong

Changed in keystone:
assignee: nobody → yong sheng gong (gongysh)

Fix proposed to branch: master
Review: https://review.openstack.org/43414

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph) on 2013-08-24
Changed in keystone:
importance: Undecided → Low
milestone: none → havana-3

Reviewed: https://review.openstack.org/43414
Committed: http://github.com/openstack/keystone/commit/42b107e4844732cdb9207bcf7dc2788cec1ef694
Submitter: Jenkins
Branch: master

commit 42b107e4844732cdb9207bcf7dc2788cec1ef694
Author: Yong Sheng Gong <email address hidden>
Date: Fri Aug 23 15:51:47 2013 +0800

    change oauth.consumer description into nullable

    Change-Id: I158e916f1f422882b83f648d7720f8f87a4c5813
    Fixes: Bug #1215482

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers