emit warning while running flake8 without virtual env

Bug #1215401 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Opinion
Wishlist
Kui Shi

Bug Description

run_tests.sh -N -p
it will call the flake8 installed on your host to detect PEP8, and
the flake8 plugin "OpenStack hacking" may not installed on your
host, so this command may not detect the OpenStack Style Commandment
supplied by hacking(e.g H202).

run_tests.sh -p
it will call the flake8 from virtual env, flake8 plugin "OpenStack
hacking" installed in virtual env will be triggered.

The result from "run_tests.sh -p" should be trusted, and jenkins uses
virtual env to run flake8 too.

When "-N" is enabled, emit warning to remind user.

Kui Shi (skuicloud)
Changed in keystone:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
Dolph Mathews (dolph) wrote :

I manage my own venv for development (as do several other developers), so I call run_tests.sh with -N to avoid a second venv being created... so you're intending to unconditionally harass me with warnings?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43363

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Wishlist
status: In Progress → Opinion
Changed in keystone:
status: Opinion → In Progress
Dolph Mathews (dolph)
Changed in keystone:
status: In Progress → Opinion
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.