UUID Token provider in keystone.conf must be set when token_format = UUID

Bug #1202651 reported by Dolph Mathews on 2013-07-18
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
High
Guang Yee

Bug Description

This review [1] illustrates that if token_format is explicitly set to UUID, then the token provider is not set by keystone correspondingly (this should happen automatically).

token_format = UUID should take precedence to provide backwards compatibility with existing configurations. If a token provider is explicitly set, then that should take precedence over token_format (or an error should be raised if they don't match).

[1]: https://review.openstack.org/#/c/37151/

Guang Yee (guang-yee) wrote :

If no one has started on working this one yet, I'll take care of it today since I created this mess.

Changed in keystone:
assignee: nobody → Guang Yee (guang-yee)

Fix proposed to branch: master
Review: https://review.openstack.org/37702

Changed in keystone:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/37702
Committed: http://github.com/openstack/keystone/commit/e63501d305c67b898821ad65ec744adf6851236a
Submitter: Jenkins
Branch: master

commit e63501d305c67b898821ad65ec744adf6851236a
Author: Guang Yee <email address hidden>
Date: Thu Jul 18 08:23:52 2013 -0700

    Support token_format for backward compatibility

    The provider property in the [token] section will be unset by default. If
    provider is not set, we will use token_format in the [signing] section to
    determine to provider. If provider is set, it must agree with the token_format.

    fixed bug 1202651

    Change-Id: I15ff67490acbbacc9eefc7eee253400475704b04

Changed in keystone:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/37711
Committed: http://github.com/openstack/keystone/commit/43213e5df24950a5c6f2a43b4426becafc6ad25a
Submitter: Jenkins
Branch: milestone-proposed

commit 43213e5df24950a5c6f2a43b4426becafc6ad25a
Author: Guang Yee <email address hidden>
Date: Thu Jul 18 08:23:52 2013 -0700

    Support token_format for backward compatibility

    The provider property in the [token] section will be unset by default. If
    provider is not set, we will use token_format in the [signing] section to
    determine to provider. If provider is set, it must agree with the token_format.

    fixed bug 1202651

    Change-Id: I15ff67490acbbacc9eefc7eee253400475704b04

Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers