Unable to get local config from wsgi middleware

[Alvaro Lopez]

I am unable to get the local configuration for a wsgi middleware:

    [filter:myfilter]
    factory = ...
    variable = foo

I am expecting to get the __init__ method called with kwargs = {"variable": "foo"} but it is not. This is because the keystone.common.wsgi.Middleware.factory() method returns cls(app) instead of cls(app, **local_config)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/33039

[Alvaro Lopez (aloga)]

Hi Dolph.

This should not be tagged as wishlist, because the code states that this is the expected behaviour (see factory method of keystone.common.wsgi.Middleware) and because this was introduced only after this commit was merged: https://github.com/openstack/keystone/commit/feadf7576058f47f2bb1f0bc097d45101e8c1562

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/33039
Committed: http://github.com/openstack/keystone/commit/a48488764a38961a66ad07c4bf629f220f80334c
Submitter: Jenkins
Branch: master

commit a48488764a38961a66ad07c4bf629f220f80334c
Author: Alvaro Lopez Garcia <email address hidden>
Date: Fri Jun 14 13:47:10 2013 +0200

    wsgi.Middleware factory should use **kwargs

    Fixes bug 1190978

    Change-Id: Ifb0673b7aab5292c13bf5c86c5cc2de8096f7e3e

[Dolph Mathews (dolph)]

The same is applied to BaseApplication and Router in https://review.openstack.org/#/c/34174/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/34174
Committed: http://github.com/openstack/keystone/commit/8f1c5840d9eb65e4dfa48e54710d42b18dadd77e
Submitter: Jenkins
Branch: master

commit 8f1c5840d9eb65e4dfa48e54710d42b18dadd77e
Author: Alvaro Lopez Garcia <email address hidden>
Date: Mon Jun 24 11:08:48 2013 +0200

    wsgi.BaseApplication and wsgi.Router factories should use **kwargs

    Also removed wrong references to nova in docstrings.

    This is related with bug 1190978

    Change-Id: I1b945596d4ebe39d03069b590b7f1a444eaef72f