When a new v3 credential of ec2 type is created, we store it with a new credential id in the backend

Bug #1185582 reported by Nachiappan on 2013-05-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Wishlist
Nachiappan

Bug Description

When a new v3 credential of ec2 type is created, we store it with a new credential id in the id column in backend.

It would be preferred to store the access key id in the id column in backend when the credential of type ec2 is created.

Nachiappan (nachiappan) on 2013-05-29
Changed in keystone:
assignee: nobody → Nachiappan (nachiappan-veerappan-nachiappan)
Dolph Mathews (dolph) on 2013-05-29
Changed in keystone:
status: New → Triaged
importance: Undecided → Wishlist
Dolph Mathews (dolph) wrote :

(from IRC)

Rather than storing the plain text value of the access key in the id column of the credential table, which would force clients to URL-encode the access key, I'd suggest having the EC2 controller hash the access key and set that as the primary key. That way, clients of the /v3/credentials API are otherwise unaffected.

Changed in keystone:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/31290
Committed: http://github.com/openstack/keystone/commit/299c1933f3f51b37649f3995d65ac8a841d3dc5e
Submitter: Jenkins
Branch: master

commit 299c1933f3f51b37649f3995d65ac8a841d3dc5e
Author: Nachiappan VR N <email address hidden>
Date: Thu May 30 14:00:38 2013 -0700

    Store hash of access as primary key for ec2 type.

    In current v3 credential implementation when
    a new ec2 credential is created we store it with
    new credential id in the backend. This fix is provided
    to store the hash of access key id as credential
    id when a new ec2 v3 credential is created.

    Fixes Bug #1185582

    Change-Id: I0ad9aaa3282b101adb6228582f0d24349232ce18

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in keystone:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers