run_test.sh uses pep8 not flake8

Bug #1180609 reported by Adam Young on 2013-05-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Dolph Mathews
python-keystoneclient
Low
Jaime Gil de Sagredo

Bug Description

pep8 has been replaced with flake8 for the gate. If we run pep8, we miss some of the checks that happen upstream, and patches won't merge

Dolph Mathews (dolph) on 2013-06-04
Changed in python-keystoneclient:
importance: Undecided → Low
Changed in keystone:
importance: Undecided → Low
status: New → Confirmed
Changed in python-keystoneclient:
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/31678

Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/31678
Committed: http://github.com/openstack/keystone/commit/766da68c4df200f3656cbdae47b32c3822ba8c77
Submitter: Jenkins
Branch: master

commit 766da68c4df200f3656cbdae47b32c3822ba8c77
Author: Dolph Mathews <email address hidden>
Date: Tue Jun 4 12:27:11 2013 -0500

    run_tests.sh should use flake8 (bug 1180609)

    Existing flags (e.g. --pep8) are intentionally left alone.

    Change-Id: I300aaee17294b88c7d1ba4daad462af407c67d4f

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-07-17
Changed in keystone:
milestone: none → havana-2
status: Fix Committed → Fix Released
Changed in python-keystoneclient:
assignee: nobody → Jaime Gil de Sagredo (jaimegildesagredo)
Changed in python-keystoneclient:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/39912
Committed: http://github.com/openstack/python-keystoneclient/commit/63c755e1ae0be13d7ee233ffae5508f1cca97a51
Submitter: Jenkins
Branch: master

commit 63c755e1ae0be13d7ee233ffae5508f1cca97a51
Author: Jaime Gil de Sagredo Luna <email address hidden>
Date: Fri Aug 2 14:21:07 2013 +0200

    Use flake8 in run_tests.sh and updated ignore flake8 rules with tox.ini

    Change-Id: I9ec82e4ddbaa8c9f256ff962c48dfb556948b32d
    Fixes: bug #1180609

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph) on 2013-08-22
Changed in python-keystoneclient:
milestone: none → 0.3.2
Dolph Mathews (dolph) on 2013-08-23
Changed in keystone:
status: Fix Released → Incomplete
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Changed in keystone:
status: Incomplete → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers