Some nose.exc.SkipTest() rendered as ERROR's by run_tests.sh and tox

Bug #1172794 reported by Jay Pipes on 2013-04-25
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Low
Viktor Serhieiev

Bug Description

See http://paste.openstack.org/show/36606/

The above is on a fresh checkout of trunk from today, no modifications.

You can clearly see mutiple ERROR results in the test output, and yet at the bottom of the test run you see:

Ran 1296 tests in 98.651s

OK (SKIP=82)

What's going on? This is quite worrying.

Dolph Mathews (dolph) on 2013-06-10
Changed in keystone:
importance: Undecided → Low
status: New → Confirmed
summary: - run_tests.sh hiding ERROR'd test results and returning success
+ Unit test skips reported as errors

Bug 1187810 contains an explanation, but some tests containing `raise nose.exc.SkipTest()` are being rendered as ERROR's in the run_test.sh output rather than SKIP. Actual failed tests still cause run_tests.sh to have a non-zero exit.

summary: - Unit test skips reported as errors
+ Some nose.exc.SkipTest() rendered as ERROR's
Dolph Mathews (dolph) wrote :

This is reproducible via both `run_tests.sh` and `tox`.

summary: - Some nose.exc.SkipTest() rendered as ERROR's
+ Some nose.exc.SkipTest() rendered as ERROR's by run_tests.sh
summary: - Some nose.exc.SkipTest() rendered as ERROR's by run_tests.sh
+ Some nose.exc.SkipTest() rendered as ERROR's by run_tests.sh and tox
Changed in keystone:
assignee: nobody → Victor Sergeyev (vsergeyev)

Fix proposed to branch: master
Review: https://review.openstack.org/38807

Changed in keystone:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/38807
Committed: http://github.com/openstack/keystone/commit/7c28b2753dd8fe176d734b803e0fb8abddc7e08c
Submitter: Jenkins
Branch: master

commit 7c28b2753dd8fe176d734b803e0fb8abddc7e08c
Author: Victor Sergeyev <email address hidden>
Date: Fri Jul 26 16:45:59 2013 +0300

    Scipped tests don't render as ERROR's

    Replaced `raise nose.exc.SkipTest()` statement to self.skipTest().
    Removed unused nose.exc imports.

    Fixes bug 1172794

    Change-Id: Ieb353864acadef43508d185156c7fa1667baa845

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2013-09-05
Changed in keystone:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers