low performance with SQL token backends

[Sylvain Afchain]

I'm currently using the SQL token backends, and i have poor performances with a not so high number of tokens. It seems there is no index on the table.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/26845

[Brant Knudson (blk-u)]

Interestingly, I was working on a system where this fix would have been useful (as a workaround) today.

The test was for stability/scalability, so it was running for several hours booting instances. Keystone's token table got to about 1 million rows, mostly because nova using quantum creates a new token for every quantum op as far as I can tell.

Eventually, getting the revoked tokens list takes ~9 seconds, and then nova fails because quantum's getting token times out (so they blame Keystone of course).

Creating the index made it so that the query to get the revoked tokens list now takes < 1 second again.

Of course, the real fix is that nova/quantum should re-use its token rather than getting a new one every time.

[Malini Bhandaru (malini-k-bhandaru)]

A related bug: https://bugs.launchpad.net/keystone/+bug/1178063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30749

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30753

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30749
Committed: http://github.com/openstack/keystone/commit/2879d42de12cfb5a141197debbf7eaa53cd6750f
Submitter: Jenkins
Branch: master

commit 2879d42de12cfb5a141197debbf7eaa53cd6750f
Author: Sylvain Afchain <email address hidden>
Date: Tue May 28 17:45:04 2013 +0200

    Add index on expires column of the SQL token Backend

    Add migration script to add the index.

    bp index-token-expiry

    Change-Id: I36934c18979df5037d606d4846b29194750847af
    Fixes: bug #1168399

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30753
Committed: http://github.com/openstack/keystone/commit/9faf255cf54c1386527c67a2d75074c547aa407a
Submitter: Jenkins
Branch: master

commit 9faf255cf54c1386527c67a2d75074c547aa407a
Author: Sylvain Afchain <email address hidden>
Date: Tue May 28 17:54:23 2013 +0200

    Add index on valid column of the SQL token Backend

    Add migration script to add the index

    Change-Id: I0d7e231b32040dfb57c2e8023a7f45d65416763c
    Fixes: bug #1168399