non-default auth plugins can't be configured

Bug #1157515 reported by Dolph Mathews on 2013-03-20
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Medium
Davanum Srinivas (DIMS)
Grizzly
Medium
Dolph Mathews

Bug Description

Attempting to register a custom auth plugin has no effect.

It looks like the code in keystone.config should actually be failing if it got that far ('config' does not exist). Instead, I'm guessing that when the for loop below is hit in keystone.config, CONF.auth.methods still has the default values (not what is defined in the config file):

  # register any non-default auth methods here (used by extensions, etc)
  for method_name in CONF.auth.methods:
    if method_name not in _DEFAULT_AUTH_METHODS:
      config.register_str(method_name, group='auth')

So the condition inside the for loop can never be true, and no custom methods will be registered.

Fix proposed to branch: master
Review: https://review.openstack.org/24900

Changed in keystone:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/24919

Reviewed: https://review.openstack.org/24900
Committed: http://github.com/openstack/keystone/commit/cbac77110ee1d7b9abc5a23f973dab27e8b32015
Submitter: Jenkins
Branch: master

commit cbac77110ee1d7b9abc5a23f973dab27e8b32015
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 20 14:22:36 2013 -0400

    Fix for configuring non-default auth plugins properly

    Make sure we pick up CONF.auth.methods from configuration
    files. Added a test case to make sure the we don't regress

    Fixes LP# 1157515

    Change-Id: I70290c37b2a5378b5247a14e3bfa20d50bf8fe74

Changed in keystone:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/26604
Committed: http://github.com/openstack/keystone/commit/9446a999c5f7748beeb9145a287d7292c632c896
Submitter: Jenkins
Branch: stable/grizzly

commit 9446a999c5f7748beeb9145a287d7292c632c896
Author: Davanum Srinivas <email address hidden>
Date: Wed Mar 20 14:22:36 2013 -0400

    Fix for configuring non-default auth plugins properly

    Make sure we pick up CONF.auth.methods from configuration
    files. Added a test case to make sure the we don't regress

    Fixes LP# 1157515

    Change-Id: I70290c37b2a5378b5247a14e3bfa20d50bf8fe74

tags: removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in keystone:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in keystone:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers