keystoneclient and keystone has a duplicate common/cms.py

[Chmouel Boudjnah]

There is two cms.py in keystoneclient and keystone, should we :

1) keep the one in keystoneclient and make keystone using it.
2) move it to openstack-common
3) keep it as it is.

in any case we will need to sync them (probably the one from keystone is the accurate one) :

http://pastie.org/private/izldwojqcuhlhniq8cbtg

[Dolph Mathews (dolph)]

keystone.common.cms should be removed in favor of keystoneclient.common.cms as keystone depends on keystoneclient.

[Pradeep Kilambi (pkilambi)]

I can look at this. @Dolph, so for this bug, looks like all we need to do is remove the keystone.common.cms, update keystone's import references to use keystoneclient.common.cms . Doesn't look like we need to do anything in keystone client for this? could we just keep the keystone bug and close the keystoneclient one? or am i missing something here?

[Dolph Mathews (dolph)]

Unassigning due to inactivity.

[Dolph Mathews (dolph)]

(just noticed Pradeep's question that I totally failed to answer) I added keystoneclient to this bug in case the two codebases have diverged to any extent. If that's the case, any new the additions in keystone might need to be added to keystoneclient.

[Chmouel Boudjnah (chmouel)]

@Pradeep feel free to take this if you like since now that Dolph had replied, either way we probably would need to make sure the two versions are in sync.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/50555

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/51772

[Jeffrey Zhang (jeffrey4l)]

Is there any way that the keystone can use the python-keystoneclient I modified when running UT?

[Dolph Mathews (dolph)]

Jeffrey: keystone will use whatever instance of keystoneclient is available in the python path.

[Jeffrey Zhang (jeffrey4l)]

@dolph,
Yes, I know that.
My problem is "All the UTs in the https://review.openstack.org/50555 failed, because I changed some method signature in the python-keystoneclient". So the keystone will be not successful until the python-keystoneclient I changed is merged in to master.

I want know, whether there is another way besides waiting for the merge.

[Dolph Mathews (dolph)]

Ah, because it's cross-project, we currently have to merge them in order... until:

  https://bugs.launchpad.net/openstack-ci/+bug/1021879

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51772
Committed: http://github.com/openstack/python-keystoneclient/commit/0c8faa3efc81ea4d2d93f64c118a965091bdf5b4
Submitter: Jenkins
Branch: master

commit 0c8faa3efc81ea4d2d93f64c118a965091bdf5b4
Author: Lei Zhang <email address hidden>
Date: Tue Oct 15 11:21:56 2013 +0800

    Migrate the keystone.common.cms to keystoneclient

    - Add checking the openssl return code 2, related to following review

      https://review.openstack.org/#/c/22716/

    - Add support set subprocess to the cms, when we already know which
      subprocess to use.

    Closes-Bug: #1142574
    Change-Id: I3f86e6ca8bb7738f57051ce7f0f5662b20e7a22b

[Morgan Fainberg (mdrnstm)]

This has been fixed in keystone as of Feb 5 2014,

https://github.com/openstack/keystone/commit/ae4626a857b3fec39a7a538f0ddbfad22cde5e34