Remove KVS Backend

Bug #1077282 reported by Adam Young
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Morgan Fainberg

Bug Description

We no longer need to use the KVS backend, as the SQLite backend with in memory database has the same capabilties and can and should be used for all of the unit tests. This will reduce the amount of code we have to maintain.

Revision history for this message
Dolph Mathews (dolph) wrote :

Each KVS driver is in a different situation:

- kvs policy driver is new (for v3) and can be removed immediately without seeing a release
- kvs identity driver is probably the easiest existing kvs driver to remove, and the most complex to maintain
- kvs catalog driver is the basis for the templated driver, although that inheritance could change to the sql driver
- kvs token driver has been documented, and should at least be maintained for a deprecation period

ayoung: if you don't mind, I'd like to see this issue target the kvs identity driver in particular.

Joseph Heck (heckj)
Changed in keystone:
status: New → Triaged
importance: Undecided → Low
Dolph Mathews (dolph)
Changed in keystone:
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116528

Henry Nash (henry-nash)
Changed in keystone:
assignee: nobody → Henry Nash (henry-nash)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/116528
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a2b0f8a3ea09385a283b852c860f0eaacf2c85b3
Submitter: Jenkins
Branch: master

commit a2b0f8a3ea09385a283b852c860f0eaacf2c85b3
Author: Henry Nash <email address hidden>
Date: Sun Aug 24 22:54:15 2014 +0100

    Make SQL the default backend for Identity & Assignment unit tests.

    We have a goal to deprecate the kvs backends for Identity and
    Assignment. Before we can do this, we need to ensure our unit
    tests are not dependant on them. This patch sets the Identity
    backend for unit tests to SQL. Since, by default, the Assignment
    backend will pick the same backend type as Identity, this also
    means that it will follow suit.

    As well as ensuring correct database initialization, this patch
    moves a test that was erronously in v2_auth testing to v3. The
    test was passing before due to the fact that the kvs assignment
    driver does not correctly honor the domain boundary for all
    project APIs.

    Change-Id: I7b6e753b379a43d09ad8ea077ed6796d1f2e9a26
    Partially-Closes: bug 1077282

Dolph Mathews (dolph)
Changed in keystone:
milestone: none → next
Changed in keystone:
assignee: Henry Nash (henry-nash) → David Stanek (dstanek)
status: Triaged → In Progress
Changed in keystone:
assignee: David Stanek (dstanek) → Morgan Fainberg (mdrnstm)
Changed in keystone:
milestone: next → none
Changed in keystone:
assignee: Morgan Fainberg (mdrnstm) → David Stanek (dstanek)
Changed in keystone:
milestone: none → mitaka-2
milestone: mitaka-2 → none
Changed in keystone:
assignee: David Stanek (dstanek) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → David Stanek (dstanek)
Changed in keystone:
assignee: David Stanek (dstanek) → Dave Chen (wei-d-chen)
Dave Chen (wei-d-chen)
Changed in keystone:
assignee: Dave Chen (wei-d-chen) → David Stanek (dstanek)
Changed in keystone:
assignee: David Stanek (dstanek) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → David Stanek (dstanek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/158442
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b1b4350017c8e0177193b3b013c3d9c9f9b9d23a
Submitter: Jenkins
Branch: master

commit b1b4350017c8e0177193b3b013c3d9c9f9b9d23a
Author: David Stanek <email address hidden>
Date: Tue Feb 17 19:05:56 2015 +0000

    Removes KVS catalog backend

    The templated backend relied on the KVS backend to implement some
    functionality. The functionality (CRUD for endpoint, services, etc.) is
    arguably incorrect since it won't actually change the contents of the
    catalog. The read only methods have been fixed to use the templated data
    and the write methods raise NotImplemented.

    bp: removed-as-of-mitaka
    Partial-Bug: #1077282
    Closes-Bug: #1367113
    Closes-Bug: #1269789
    Change-Id: Iaa68b18f0b6d7e9f5dc0cbf7d21a3d90dcdc1ea4

Revision history for this message
Steve Martinelli (stevemar) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: David Stanek (dstanek) → nobody
status: In Progress → Triaged
Changed in keystone:
assignee: nobody → Steve Martinelli (stevemar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/426009
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=c2fdd3b3bfbc089df14c9b1457282e0c7cb74475
Submitter: Jenkins
Branch: master

commit c2fdd3b3bfbc089df14c9b1457282e0c7cb74475
Author: Steve Martinelli <email address hidden>
Date: Thu Jan 26 20:09:12 2017 -0500

    add additional deprecation warnings for KVS options

    We had a single deprecation warning for KVS functionality being
    removed in Pike, located at keystone/common/kvs/core.py [1]

    This change adds deprecation warnings to the various config
    options and backends that used core.py.

    [1] https://github.com/openstack/keystone/blob/master/keystone/common/kvs/core.py#L98-L101

    Related-Bug: 1077282

    bp deprecated-as-of-ocata

    Change-Id: Ia63f0ac8543cf1e938baa712e21f08f582dc26ed

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Patch that removes all of KVS from keystone now that Pike is open for development [0].

[0] https://review.openstack.org/#/c/424862/

Changed in keystone:
assignee: Steve Martinelli (stevemar) → nobody
assignee: nobody → Morgan Fainberg (mdrnstm)
Changed in keystone:
milestone: none → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/424862
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b8b1e189306539007b6afa052b6c9f909cad41a0
Submitter: Jenkins
Branch: master

commit b8b1e189306539007b6afa052b6c9f909cad41a0
Author: Morgan Fainberg <email address hidden>
Date: Tue Jan 24 13:44:59 2017 -0800

    Remove KVS code

    KVS Code (core) and items depending on it was deprecated in Newton slated
    for removal in Pike.

    implements bp removed-as-of-pike
    Closes-Bug: 1077282
    Change-Id: I6ed4e3688f2a63b0fc439527957bc027db8d5d66

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 12.0.0.0b1

This issue was fixed in the openstack/keystone 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.